[12.0][FIX] control vat format on vat client listing #216

victor-champonnois · 2024-03-01T15:25:56Z

Belgian VAT number now can start with a 1 rather than a 0 (see https://www.easytax.co/fr/tax-mag/info/belgique-changement-de-format-pour-les-numeros-de-tva-belges/)

Also autoremove the dots in the VAT numbers (they are not checked by the VIES control, but produce errors in the VAT client listing report)

forward ported in v14 : #217

huguesdk · 2024-03-04T10:00:33Z

l10n_be_vat_reports/wizard/partner_vat_list.py

-        company_vat = company_vat.replace(" ", "").upper()
+        company_vat = company_vat.replace(" ", "").replace(".", "").upper()


since this is done in 2 places, it should go into a function.

also, to avoid multiple replace operations, re.sub() can be used:

company_vat = re.sub("[ .]", "", company_vat).upper()

or maybe use fix_eu_vat_number() from the base_vat module directly?

yes, using fix_eu_vat_number works, and it's a better solution, thanks :)
I port this change to the 14 branch

huguesdk · 2024-03-04T10:01:56Z

l10n_be_vat_reports/wizard/partner_vat_list_client.py

-        be_vat_pattern = re.compile(r"^BE0[1-9]{1}[0-9]{8}$")
+        be_vat_pattern = re.compile(r"^BE[0-1][0-9]{9}$")


the previous pattern forbid numbers starting with "00", while this does not. is this ok?

Yes, according to this source, the format is 0xxx.xxx.xxx or 1xxx.xxx.xxx

huguesdk

just one slight change to do, squash all commits and we’ll be good to go. approving already to save time.

edit: and pre-commit should be run.

huguesdk · 2024-03-06T12:40:40Z

l10n_be_vat_reports/wizard/partner_vat_list.py

@@ -140,7 +141,8 @@ def get_partners(self):
        self.env.cr.execute(query, args)
        seq = 0
        for record in self.env.cr.dictfetchall():
-            record["vat"] = record["vat"].replace(" ", "").upper()
+            be_id = self.env.ref("base.be").id


this line should be moved out of the loop.

Belgian VAT number now can start with a 1 rather than a 0 (see https://www.easytax.co/fr/tax-mag/info/belgique-changement-de-format-pour-les-numeros-de-tva-belges/)

victor-champonnois · 2024-03-06T13:33:52Z

@huguesdk done !

robinkeunen

LGTM thanks !

robinkeunen · 2024-04-19T09:43:36Z

/ocabot merge minor

OCA-git-bot · 2024-04-19T09:44:00Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-216-by-robinkeunen-bump-minor, awaiting test results.

Signed-off-by robinkeunen

OCA-git-bot · 2024-04-19T09:45:15Z

@robinkeunen your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-216-by-robinkeunen-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

github-actions · 2024-08-18T12:30:06Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

huguesdk · 2024-08-19T08:12:33Z

@OCA/local-belgium-maintainers could you please merge this?

sbidoul · 2024-08-19T09:30:25Z

/ocabot merge patch

OCA-git-bot · 2024-08-19T09:30:32Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-216-by-sbidoul-bump-patch, awaiting test results.

Signed-off-by sbidoul

OCA-git-bot · 2024-08-19T09:32:07Z

@sbidoul your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-216-by-sbidoul-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

sbidoul · 2024-08-19T10:07:14Z

Hm weird error. I'll need to look into this.

github-actions · 2024-12-29T12:31:01Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

huguesdk · 2025-01-06T11:45:40Z

@sbidoul i guess the ci on 12.0 is deprecated? can this be merged manually, then (if yes, should we increment de version before)? anyway, could you remove the stale label and add no stale?

sbidoul · 2025-01-06T12:46:55Z

@huguesdk I had lost track of this. v12 is still supported in OCA. Could you rebase?

huguesdk · 2025-01-06T13:03:27Z

@sbidoul the branch is already based on the latest commit of 12.0.

sbidoul · 2025-01-06T13:06:00Z

/ocabot merge patch

OCA-git-bot · 2025-01-06T13:06:12Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-216-by-sbidoul-bump-patch, awaiting test results.

Signed-off-by sbidoul

OCA-git-bot · 2025-01-06T13:07:38Z

@sbidoul your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-216-by-sbidoul-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

sbidoul · 2025-01-06T13:13:57Z

Ah, I see. Same as OCA/l10n-spain#3733 (comment). Could you try the procedure explained there?

huguesdk · 2025-01-06T14:06:45Z

@sbidoul i get exactly the same error:

(...)
xlwt==1.3.0
yarl==1.7.2
zeep==4.1.0
zope.event==4.6
zope.interface==5.5.2
+ echo addons_path=/opt/odoo/addons,.
+ cat /etc/odoo.cfg
[options]
addons_path=/opt/odoo/addons,.
++ oca_list_external_dependencies deb
could not obtain odoo.addons.__path__ using python
not found in addons path: base,base_vat_sanitized,mis_builder,partner_identification,report_xml,web_notify
Aborted.
+ deps=

before running oca_install_addons, /etc/odoo.cfg contains only:

[options]

after running it, it contains:

[options]
addons_path=/opt/odoo/addons,.

it doesn’t find the base module because it is in /opt/odoo/odoo/addons, which is not in the addons_path. the other modules that are not found are oca modules (which i guess should be automatically installed from pypi). report_xml and web_notify are from repositories that are not in oca_dependencies.txt, but adding them doesn’t have any effect.

sbidoul · 2025-01-06T14:23:47Z

Sorry, I meant adding lxml<5.2 in test-requirements.txt, like they did in l10n-spain in OCA/l10n-spain#3762

sbidoul · 2025-01-06T14:27:36Z

You can see the error by running docker run -it --rm -v .:/_build --workdir /_build ghcr.io/oca/oca-ci/py3.6-odoo12.0 bash, then oca_install_addons, then odoo.

huguesdk · 2025-01-06T14:42:28Z

@sbidoul indeed, that did it, thanks! i created a separate branch for this (where i also addedd the missing repositories in oca_dependencies.txt: #233.

sbidoul · 2025-01-06T14:54:19Z

/ocabot merge patch

OCA-git-bot · 2025-01-06T14:54:26Z

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-216-by-sbidoul-bump-patch, awaiting test results.

OCA-git-bot · 2025-01-06T15:00:07Z

Congratulations, your PR was merged at dd7d851. Thanks a lot for contributing to OCA. ❤️

huguesdk · 2025-01-06T15:01:10Z

yes, finally! many thanks, @sbidoul!

victor-champonnois mentioned this pull request Mar 1, 2024

[14.0][FIX] control vat format on vat client listing #217

Merged

victor-champonnois force-pushed the 12.0-fix-vat-check-on-vat-client-list branch from 58f7d28 to 6ee6d81 Compare March 1, 2024 15:55

victor-champonnois changed the title ~~[12.0][FIX] control on vat format~~ [12.0][FIX] control vat format on vat client listing Mar 1, 2024

huguesdk suggested changes Mar 4, 2024

View reviewed changes

victor-champonnois force-pushed the 12.0-fix-vat-check-on-vat-client-list branch from 2139d9c to 1224070 Compare March 6, 2024 11:21

huguesdk approved these changes Mar 6, 2024

View reviewed changes

victor-champonnois and others added 2 commits March 6, 2024 14:17

[FIX] control on vat format

5c38037

Belgian VAT number now can start with a 1 rather than a 0 (see https://www.easytax.co/fr/tax-mag/info/belgique-changement-de-format-pour-les-numeros-de-tva-belges/)

[IMP] autoremove points in VAT numbers

0a56ed1

victor-champonnois force-pushed the 12.0-fix-vat-check-on-vat-client-list branch from 1224070 to 0a56ed1 Compare March 6, 2024 13:29

robinkeunen approved these changes Apr 19, 2024

View reviewed changes

OCA-git-bot added the approved label Apr 19, 2024

OCA-git-bot added a commit that referenced this pull request Apr 19, 2024

Merge PR #216 into 12.0

549de66

Signed-off-by robinkeunen

OCA-git-bot added the bot is merging ⏳ label Apr 19, 2024

OCA-git-bot removed the bot is merging ⏳ label Apr 19, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024

OCA-git-bot added a commit that referenced this pull request Aug 19, 2024

Merge PR #216 into 12.0

3f30e00

Signed-off-by sbidoul

OCA-git-bot added the bot is merging ⏳ label Aug 19, 2024

OCA-git-bot removed the bot is merging ⏳ label Aug 19, 2024

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 29, 2024

OCA-git-bot added a commit that referenced this pull request Jan 6, 2025

Merge PR #216 into 12.0

adee9b6

Signed-off-by sbidoul

OCA-git-bot added the bot is merging ⏳ label Jan 6, 2025

OCA-git-bot removed the bot is merging ⏳ label Jan 6, 2025

huguesdk mentioned this pull request Jan 6, 2025

[12.0][FIX] fix ci requirements #233

Merged

OCA-git-bot added the bot is merging ⏳ label Jan 6, 2025

OCA-git-bot merged commit 42bab7c into OCA:12.0 Jan 6, 2025
4 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][FIX] control vat format on vat client listing #216

[12.0][FIX] control vat format on vat client listing #216

victor-champonnois commented Mar 1, 2024 •

edited

Loading

huguesdk Mar 4, 2024

victor-champonnois Mar 6, 2024

huguesdk Mar 4, 2024

victor-champonnois Mar 6, 2024

huguesdk left a comment •

edited

Loading

huguesdk Mar 6, 2024

victor-champonnois commented Mar 6, 2024

robinkeunen left a comment

robinkeunen commented Apr 19, 2024

OCA-git-bot commented Apr 19, 2024

OCA-git-bot commented Apr 19, 2024

github-actions bot commented Aug 18, 2024

huguesdk commented Aug 19, 2024

sbidoul commented Aug 19, 2024

OCA-git-bot commented Aug 19, 2024

OCA-git-bot commented Aug 19, 2024

sbidoul commented Aug 19, 2024

github-actions bot commented Dec 29, 2024

huguesdk commented Jan 6, 2025

sbidoul commented Jan 6, 2025

huguesdk commented Jan 6, 2025

sbidoul commented Jan 6, 2025

OCA-git-bot commented Jan 6, 2025

OCA-git-bot commented Jan 6, 2025

sbidoul commented Jan 6, 2025

huguesdk commented Jan 6, 2025

sbidoul commented Jan 6, 2025

sbidoul commented Jan 6, 2025

huguesdk commented Jan 6, 2025

sbidoul commented Jan 6, 2025

OCA-git-bot commented Jan 6, 2025

OCA-git-bot commented Jan 6, 2025

huguesdk commented Jan 6, 2025

		company_vat = company_vat.replace(" ", "").upper()
		company_vat = company_vat.replace(" ", "").replace(".", "").upper()

		be_vat_pattern = re.compile(r"^BE0[1-9]{1}[0-9]{8}$")
		be_vat_pattern = re.compile(r"^BE[0-1][0-9]{9}$")

[12.0][FIX] control vat format on vat client listing #216

[12.0][FIX] control vat format on vat client listing #216

Conversation

victor-champonnois commented Mar 1, 2024 • edited Loading

huguesdk Mar 4, 2024

Choose a reason for hiding this comment

victor-champonnois Mar 6, 2024

Choose a reason for hiding this comment

huguesdk Mar 4, 2024

Choose a reason for hiding this comment

victor-champonnois Mar 6, 2024

Choose a reason for hiding this comment

huguesdk left a comment • edited Loading

Choose a reason for hiding this comment

huguesdk Mar 6, 2024

Choose a reason for hiding this comment

victor-champonnois commented Mar 6, 2024

robinkeunen left a comment

Choose a reason for hiding this comment

robinkeunen commented Apr 19, 2024

OCA-git-bot commented Apr 19, 2024

OCA-git-bot commented Apr 19, 2024

github-actions bot commented Aug 18, 2024

huguesdk commented Aug 19, 2024

sbidoul commented Aug 19, 2024

OCA-git-bot commented Aug 19, 2024

OCA-git-bot commented Aug 19, 2024

sbidoul commented Aug 19, 2024

github-actions bot commented Dec 29, 2024

huguesdk commented Jan 6, 2025

sbidoul commented Jan 6, 2025

huguesdk commented Jan 6, 2025

sbidoul commented Jan 6, 2025

OCA-git-bot commented Jan 6, 2025

OCA-git-bot commented Jan 6, 2025

sbidoul commented Jan 6, 2025

huguesdk commented Jan 6, 2025

sbidoul commented Jan 6, 2025

sbidoul commented Jan 6, 2025

huguesdk commented Jan 6, 2025

sbidoul commented Jan 6, 2025

OCA-git-bot commented Jan 6, 2025

OCA-git-bot commented Jan 6, 2025

huguesdk commented Jan 6, 2025

victor-champonnois commented Mar 1, 2024 •

edited

Loading

huguesdk left a comment •

edited

Loading