-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][WIP] Importação de Documentos Fiscais, Integração com Compras e Estoque #2994
Conversation
some ideas from OCA#1412
Caso de Uso:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mileo so basically what you are adding atop of the PR's I made to import the NFe is a new module called l10n_br_nfe_stock and some more code in l10n_br_purchase to sync stock.pickings or purchase.orders with the imported account.move.
The problem is 90% of such code is not specific to the Brazilian localization! In fact everybody in the world importing invoices into Odoo will have interest in relating them with purchase.order and or stock.picking. And with the increase of Odoo EDI capabilities both in the EE and in the OCA it means this is becoming a hot topic in the OCA.
What will happen if we increase the l10n-brazil codebase to deal with that is we will have an even more complex code to migrate and maintain while the rest of the OCA will do something much cleaner with a wider ecosystem in OCA/edi and we will have yet another pile of shitty code to maintain here for nothing.
Sorry but in 10 years of you contributing in the repo, the repo has been full of KMEE modules that YOU USUALLY DON"T MAINTAIN. Just in the fiscal module your last addition of the broken DFe stuff in 2019 led to 500 lines of pure dead code in l10n_br_fiscal for 4 years and the list of un maintained KMEE code in the repo is just huge (I can write it down if you force me too). What about your "financial in fiscal" great idea? What about your proposals to reinvent the deductible Odoo taxes, your proposal to reinvent the IFRS for stock, your proposal to shortcut the account module as you did in your great fork? And I'm pretty sure you think your code in github.com/erpbrasil is OK, well that's a big problem because we are several to think it's far below OCA standards. It sucks because usually it's us who maintain that code, fix the lint issues, fix the broken tests that break the tests in the whole repo (your website* module remember?). So adding code without maintaining it sucks and I have to make it clear. You had more than 10 years to prove you could add great code in the repo and you did pretty much the opposite all these years sadly. You'll probably again tell it's my own opinion and you do great stuff. But if you did great stuff and that was just me persecuting you, in 12 years you would have managed to put more than one single module in the other OCA repo don't you think?
So basically I quite opposed you add code to do these things in the existing modules or even as new modules.
I would advise you to try putting new modules into https://github.com/OCA/edi instead because this is where this logic belongs. And then eventually we could have a couple of overrides in the project to take xPed or nItem stuff into account specifically.
You could start around my colleague @alexis-via proposal here OCA/edi#803
cc @renatonlima @marcelsavegnago @antoniorubiopesol @felipemotter @mbcosta @douglascstd
@rvalyi eu estou removendo o módulo l10n_br_nfe_stock que foi feito pelo @hirokibastos no PR (#2735) e limpando o código, esse é primeiro passo. Também estou aproveitando a arquitetura o que você implementou na nos dois PRs citados (#2761 e #2781) Você chegou a ler o que eu escrevi acima? Com certeza aberto a sugestões na implementação e vou dar uma olhada no código do EDI. Mas também considerando a integração com o estoque e compras. |
[IMP] Import Fiscal Document in Purchase
[IMP] Import Fiscal Document in Stock
[REM] Views
76381c4
to
15eb0fe
Compare
Hi @renatonlima, @rvalyi, @antoniospneto, @mbcosta, @felipemotter, |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Inclui e/ou depende de:
Objetivos:
Este PR provavelmente vai ser quebrado em PRs menores ou alguns commits serão unidos.