[16.0][REF] l10n_br_stock_account: Usando o Common Test do stock_picking_invoicing e removendo campo já informado #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @renatonlima, |
marcelsavegnago
requested review from
antoniospneto,
mileo,
kaynnan and
WesleyOliveira98
kaynnan
approved these changes
Jan 23, 2025
rvalyi
approved these changes
Jan 24, 2025
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 753b5c2. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use common tests from stock_picking_invoicing.
PR com duas alterações simples:
Usando o Common Test do stock_picking_invoicing, a partir da v16 é possível herdar de uma forma melhor os Testes do stock_picking_invoicing e com isso podemos reduzir código na Localização
Durante a Revisão do sale_stock_picking_invoicing foi visto que era melhor mover o que era feito no objeto stock_rule para o modulo stock_picking_invoicing e com isso podemos retirar a Linha que informa o invoice_state porque isso já está sendo informado aqui https://github.com/OCA/account-invoicing/blob/16.0/stock_picking_invoicing/models/stock_rule.py#L13 .
Olhando o código que existe no stock_rule dentro da Localização surgiu uma questão que é se devemos mover esse código para o stock_picking_invoicing e com isso adicionar essa funcionalidade de poder definir a partir do Stock Rule com qual invoice_state o Picking deve ser criado, o que vocês acham? Isso não precisa ser feito agora e pode ser apenas um Roadmap
cc @OCA/local-brazil-maintainers