Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FW] l10n_it_declaration_of_intent: FW of #2356 #3463

Merged

Conversation

aleuffre
Copy link
Contributor

@aleuffre aleuffre commented Jul 7, 2023

Original PR #2356

Tracking issue: #2404

Permette di emettere dichiarazioni d'intento oltre il plafond teorico, aggiungendo un check su ciò che è stato davvero speso, e non solo ciò che è stato dichiarato.

…cords that exceeds the limit_amount of dichiarazione.intento.yearly.limit

MIG v14: tweaked l10n_it_fatturapa_out_di as a result of the changes
Copy link
Contributor

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da portare/verificare poi la #2412

@sergiocorato
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3463-by-sergiocorato-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 16, 2024
Signed-off-by sergiocorato
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3463-by-sergiocorato-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 16, 2024
Signed-off-by sergiocorato
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3463-by-sergiocorato-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit caade57 into OCA:14.0 Feb 16, 2024
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4904f14. Thanks a lot for contributing to OCA. ❤️

@@ -253,6 +252,10 @@ def check_declarations_amounts(self, declarations):

def get_declaration_residual_amounts(self, declarations):
"""Get residual amount for every `declarations`."""
plafond = self.env.user.company_id.declaration_yearly_limit_ids.filtered(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per correttezza sarebbe self.company_id

@aleuffre aleuffre deleted the 14.0-declaration-intent-exceed-limit branch March 1, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

l10n_it_dichiarazione_intento: poter creare più dichiarazioni d'intento oltre il plafond disponibile
5 participants