Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_it_ricevute_bancarie: fix state update on riba lines #4568

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[14.0][FIX] l10n_it_ricevute_bancarie: fix state update on riba lines #4568

merged 1 commit into from
Jan 27, 2025

Conversation

SylweKra
Copy link

Porting per la issue #3884

@francesco-ooops francesco-ooops linked an issue Jan 20, 2025 that may be closed by this pull request
[16.0] l10n_it_riba: Azione "SEGNA TUTTE COME PAGATE" non funziona quando si seleziona su "SEGNA COME ACCREDITATA" il bottone "Salta e conferma accredito" su wizard. #3884
Closed
2 tasks
@francesco-ooops francesco-ooops mentioned this pull request Dec 13, 2024
Closed
2 tasks
@francesco-ooops
Copy link
Contributor

@salvorapi potresti fare review? Grazie!

@francesco-ooops francesco-ooops added 14.0 is porting This pull request is porting a change from another version labels Jan 22, 2025
Marco-ooops
Marco-ooops approved these changes Jan 22, 2025
View reviewed changes
Copy link

@Marco-ooops Marco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funzionale ok

GSLabIt
GSLabIt reviewed Jan 23, 2025
View reviewed changes
l10n_it_ricevute_bancarie/wizard/wizard_accreditation.py
self.env["riba.distinta"].browse(active_id).state = "accredited"
riba_distinta = self.env["riba.distinta"].browse(active_id)
riba_distinta.state = "accredited"
riba_distinta.line_ids.state = "accredited"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non ci andrebbe un qualcosa tipo: riba_distinta.mapped("line_ids").update({"state": "accredited"})

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'assegnazione funziona anche su un recordset, senza dare SingletonError. Ad esempio da Odoo Shell:

env["res.partner"].search([], limit=3).name = "pippo"

aleuffre
aleuffre approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

l10n_it_ricevute_bancarie/wizard/wizard_accreditation.py
self.env["riba.distinta"].browse(active_id).state = "accredited"
riba_distinta = self.env["riba.distinta"].browse(active_id)
riba_distinta.state = "accredited"
riba_distinta.line_ids.state = "accredited"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'assegnazione funziona anche su un recordset, senza dare SingletonError. Ad esempio da Odoo Shell:

env["res.partner"].search([], limit=3).name = "pippo"

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-4568-by-francesco-ooops-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a4e72b4 into OCA:14.0 Jan 27, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dfbca70. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marco-ooops Marco-ooops Marco-ooops approved these changes

@aleuffre aleuffre aleuffre approved these changes

@GSLabIt GSLabIt GSLabIt approved these changes

Assignees
No one assigned
Labels
14.0 approved is porting This pull request is porting a change from another version merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
7 participants
@SylweKra @francesco-ooops @OCA-git-bot @GSLabIt @aleuffre @Marco-ooops @salvorapi