Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mgmtsystem_evaluation: set template group as manager #564

Merged
merged 1 commit into from
Jan 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mgmtsystem_evaluation/models/mgmtsystem_evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@ def _compute_filter_views(self):
record.is_manager = record._get_is_manager()

def _get_is_manager(self):
return self.env.user in self.manager_ids
return self.env.user in self.manager_ids or (
self.template_id.group_id
and self.env.user in self.template_id.group_id.users
)

def _get_is_user(self):
return self.env.user == self.user_id
Expand Down
43 changes: 42 additions & 1 deletion mgmtsystem_evaluation/tests/test_evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ def setUpClass(cls):
"password": "test_nanager_login_2",
}
)
cls.group = cls.env["res.groups"].create(
{
"name": "Group",
}
)
cls.activity_1 = cls.env["mail.activity.type"].create({"name": "Activity 1"})
cls.activity_2 = cls.env["mail.activity.type"].create({"name": "Activity 2"})

Expand All @@ -72,7 +77,41 @@ def test_user(self):
f.template_id = self.template
f.resource = self.partner
evaluation = f.save()
evaluation.manager_ids = self.manager | self.manager_2
evaluation.manager_ids = self.manager
self.assertFalse(evaluation.user_id)
self.assertFalse(
self.env["mgmtsystem.evaluation"]
.with_user(self.user.id)
.search([("id", "=", evaluation.id)])
)
evaluation.draft2progress()
self.assertEqual(evaluation.user_id, self.user)
self.assertEqual(
evaluation,
self.env["mgmtsystem.evaluation"]
.with_user(self.user.id)
.search([("id", "=", evaluation.id)]),
)
self.assertTrue(evaluation.with_user(self.manager).is_manager)
self.assertFalse(evaluation.with_user(self.manager).is_user)
self.assertFalse(
self.env["mgmtsystem.evaluation"]
.with_user(self.manager_2.id)
.search([("id", "=", evaluation.id)]),
)
self.assertFalse(evaluation.with_user(self.user).is_manager)
self.assertTrue(evaluation.with_user(self.user).is_user)
self.assertEqual(1, self.partner.mgmtsystem_evaluation_count)

def test_manager(self):
self.assertEqual(0, self.partner.mgmtsystem_evaluation_count)
self.group.users = self.manager_2
self.template.group_id = self.group
with Form(self.env["mgmtsystem.evaluation"]) as f:
f.template_id = self.template
f.resource = self.partner
evaluation = f.save()
evaluation.manager_ids = self.manager
self.assertFalse(evaluation.user_id)
self.assertFalse(
self.env["mgmtsystem.evaluation"]
Expand All @@ -89,6 +128,8 @@ def test_user(self):
)
self.assertTrue(evaluation.with_user(self.manager).is_manager)
self.assertFalse(evaluation.with_user(self.manager).is_user)
self.assertTrue(evaluation.with_user(self.manager_2).is_manager)
self.assertFalse(evaluation.with_user(self.manager_2).is_user)
self.assertFalse(evaluation.with_user(self.user).is_manager)
self.assertTrue(evaluation.with_user(self.user).is_user)
self.assertEqual(1, self.partner.mgmtsystem_evaluation_count)
Expand Down
Loading