Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] mrp_multi_level: fix kit/phantom planning #1367

Conversation

matt454357
Copy link
Contributor

fixes #1362

Ignoring qty_available for phantom products prevents double counting the qty_available of components.

Creating planned orders for phantom products is simpler than recursively exploding phantom BOMs. This also makes it easier to analyze the planning data generated by the MRP calculation.

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow, @ChrisOForgeFlow, @JordiBForgeFlow,
some modules you are maintaining are being modified, check this out!

@matt454357 matt454357 force-pushed the 16.0-fix-mrp_multi_level-phantom-comp-planning branch from 266c958 to be70efc Compare October 17, 2024 20:54
@matt454357 matt454357 marked this pull request as ready for review October 21, 2024 18:33
Copy link
Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matt454357 Good catch. Please add ForgeFlow@5ae917c

cc @LoisRForgeFlow

fixes OCA#1362

Ignoring qty_available for phantom products prevents double counting the
qty_available of components.

Creating planned orders for phantom products is simpler than recursively
exploding phantom BOMs. This also makes it easier to analyze the planning data
generated by the MRP calculation.
@matt454357 matt454357 force-pushed the 16.0-fix-mrp_multi_level-phantom-comp-planning branch from be70efc to 33cf4af Compare October 29, 2024 13:54
@matt454357
Copy link
Contributor Author

@JordiBForgeFlow
I applied ForgeFlow@5ae917c as a patch, and amended my commit. Hope that works for you.

@JordiBForgeFlow
Copy link
Member

@LoisRForgeFlow What do you think about this?

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changes make sense. Tested 👍

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1367-by-LoisRForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3f3d838 into OCA:16.0 Nov 7, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 70ff84f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants