Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] mrp_bom_location: Migration to 18.0 #1470

Open
wants to merge 49 commits into
base: 18.0
Choose a base branch
from

Conversation

Kimkhoi3010
Copy link

No description provided.

LoisRForgeFlow and others added 30 commits January 22, 2025 16:39
Currently translated at 100.0% (4 of 4 strings)

Translation: manufacture-11.0/manufacture-11.0-mrp_bom_location
Translate-URL: https://translation.odoo-community.org/projects/manufacture-11-0/manufacture-11-0-mrp_bom_location/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-12.0/manufacture-12.0-mrp_bom_location
Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_bom_location/
* eficent rebranded to forgeflow
* license changed to lgpl
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-13.0/manufacture-13.0-mrp_bom_location
Translate-URL: https://translation.odoo-community.org/projects/manufacture-13-0/manufacture-13-0-mrp_bom_location/
mymage and others added 17 commits January 22, 2025 16:39
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-16.0/manufacture-16.0-mrp_bom_location
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_location/
Currently translated at 100.0% (5 of 5 strings)

Translation: manufacture-16.0/manufacture-16.0-mrp_bom_location
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_location/it/
Currently translated at 100.0% (5 of 5 strings)

Translation: manufacture-16.0/manufacture-16.0-mrp_bom_location
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_location/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-16.0/manufacture-16.0-mrp_bom_location
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_location/
Currently translated at 100.0% (5 of 5 strings)

Translation: manufacture-16.0/manufacture-16.0-mrp_bom_location
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_location/hr/
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please take the opportunity to add some unit tests? 🙏🏻

mrp_bom_location/models/mrp_bom.py Outdated Show resolved Hide resolved
mrp_bom_location/report/bom_structure.py Outdated Show resolved Hide resolved
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-mrp_bom_location branch from 2882c04 to 4c394bb Compare February 19, 2025 02:53
@Kimkhoi3010 Kimkhoi3010 marked this pull request as draft February 19, 2025 02:57
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-mrp_bom_location branch from 4c394bb to 0594fc4 Compare February 19, 2025 03:00
@Kimkhoi3010 Kimkhoi3010 marked this pull request as ready for review February 19, 2025 03:01
Comment on lines +20 to +23
if (
record.picking_type_id
and record.picking_type_id.default_location_src_id
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (
record.picking_type_id
and record.picking_type_id.default_location_src_id
):
if record.picking_type_id.default_location_src_id:

it's the same, but shorter

string="Location",
comodel_name="stock.location",
compute="_compute_location_id",
store=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly=False missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.