Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] quality_control_images_oca #1474

Closed

Conversation

edescalona
Copy link

@BinhexTeam

Allows you to add images to questions in quality control inspections.

… add attachments to quality control inspections

[16.0][IMP] quality_control_attachment_oca: Add module in setup

[16.0][ADD] quality_control_attachment_oca: This module allows you to add attachments to quality control inspections

[16.0][IMP] quality_control_attachment_oca: Add tests
@pedrobaeza
Copy link
Member

I don't think a new tab and module is needed. Just put the chatter in the standard module, and use the attachments features (including preview) for it.

@edescalona
Copy link
Author

I don't think a new tab and module is needed. Just put the chatter in the standard module, and use the attachments features (including preview) for it.

Hi @pedrobaeza , it is no longer a new tab, it is the possibility of assigning an image for each response in the inspection, as long as said response is not satisfactory.

Maybe the qc.test and qc.inspection models already have the chatter assigned.

I see that the code was not modified correctly, I will correct it so that you can see the change, thanks

…_control_images_oca. Modifying the behavior of images in inspections
@pedrobaeza
Copy link
Member

Yes, and the module name shouldn't be in plural. Anyway, I think this can be interesting to be part of the main module.

@edescalona
Copy link
Author

Yes, and the module name shouldn't be in plural. Anyway, I think this can be interesting to be part of the main module.

So what you are telling me is to make a PR to improve the original module?

@pedrobaeza
Copy link
Member

Yeah, I think so. Anyway, I think the mechanism for attaching images can be the many2many_binary (similar to the extra images in product for website_sale).

@edescalona
Copy link
Author

Yeah, I think so. Anyway, I think the mechanism for attaching images can be the many2many_binary (similar to the extra images in product for website_sale).

Ok, fine, the idea is also to be able to use the image widget to make it more dynamic on mobile, and well, attaching documents with the chatter can be solved, that is, making an integration with it. I'm already looking into the possibility of making a PR to improve the original, thanks.

@edescalona edescalona closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants