[IMP] mis-builder: set analytic account constraint in the filter when displayed #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbidoul, |
|
Blocked by #591 |
added 3 commits
December 27, 2023 14:59
This commit ensure that the context used by the `mis_report_widget` widget RPC calls is correctly computed. Previously using the `mis_analytic_domain` context key was useless as not taken into account in the widget.
This commit allows passing the name of a field corresponding to the analytic account to be passed into the domain. This is usefull when the component is directly used in a view of a model containing the analytical account.
… displayed This commit extracts, when the filters are displayed, the domain info from the `mis_analytic_domain` context key or from the analyticAccountIdField props and add it to the active filters. The system prevents the user from removing the constraint.
IT-Ideas
force-pushed
the
16.0-mis-builder_set_filter-lst
branch
from
254dccc to
1617767
Compare
IT-Ideas
changed the title
|
This PR is actually specific to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, the domain on analytic_account was not visible to the user. After this commit, the domain will be visible in the filters if they are displayed.
Blocked by #591