Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_attribute_set: Migration to 17.0 #191

Open
wants to merge 42 commits into
base: 17.0
Choose a base branch
from

Conversation

dnplkndll
Copy link

@dnplkndll dnplkndll commented Feb 5, 2025

clementmbr and others added 30 commits February 4, 2025 22:47
New organization :

- attribute_set (former base_custom_attribute)
- product_attribute_set (former pim_custom_attribute but without menus)
- pim (The "PIM application" former pim_base)
- pim_attrubute_set (depends on product_attribute_set and adds menus in
the PIM application)
And small FIX in _build_attribute_field()
[UPD] README.rst

[UPD] README.rst
[UPD] README.rst

[UPD] README.rst

[ADD] icon.png
courtesy of <[email protected]>

Apply dotfiles

[UPD] Update product_attribute_set.pot
[UPD] Update product_attribute_set.pot
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: odoo-pim-14.0/odoo-pim-14.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-14-0/odoo-pim-14-0-product_attribute_set/
Currently translated at 100.0% (27 of 27 strings)

Translation: odoo-pim-14.0/odoo-pim-14.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-14-0/odoo-pim-14-0-product_attribute_set/es_AR/
Currently translated at 100.0% (15 of 15 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/es/
Currently translated at 100.0% (15 of 15 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/es_AR/
Currently translated at 80.0% (12 of 15 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/fr/
mymage and others added 11 commits February 4, 2025 22:52
Currently translated at 100.0% (15 of 15 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/it/
Currently translated at 100.0% (15 of 15 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/tr/
Currently translated at 100.0% (17 of 17 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/it/
Currently translated at 100.0% (17 of 17 strings)

Translation: odoo-pim-16.0/odoo-pim-16.0-product_attribute_set
Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-product_attribute_set/es_AR/
@dnplkndll dnplkndll force-pushed the 17.0-MIG-product_attribute_set branch 2 times, most recently from ecf5dea to 805ab58 Compare February 5, 2025 04:03
@@ -0,0 +1 @@
odoo-addon-attribute_set @ git+https://github.com/OCA/odoo-pim.git@refs/pull/190/head#subdirectory=attribute_set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
odoo-addon-attribute_set @ git+https://github.com/OCA/odoo-pim.git@refs/pull/190/head#subdirectory=attribute_set
odoo-addon-attribute-set @ git+https://github.com/OCA/odoo-pim.git@refs/pull/190/head#subdirectory=setup/attribute_set

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not figured this out. works sometimes and other times does not but not clear how to trace the issue. updated the setup/ but I have tries this both ways on others with no luck

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug is fixed

@dnplkndll
@rousseldenis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not figured this out. works sometimes and other times does not but not clear how to trace the issue. updated the setup/ but I have tries this both ways on others with no luck

@dnplkndll You can see it in build logs of tests or runboat.

The correct procedure is explained there: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@rousseldenis
Copy link
Contributor

/ocabot migration product_attribute_set

@rousseldenis
Copy link
Contributor

@dnplkndll Thanks for this. In order to help reviewers, don't hesitate to put depending PR's link in this description

@dnplkndll dnplkndll force-pushed the 17.0-MIG-product_attribute_set branch from 805ab58 to f241137 Compare February 5, 2025 12:18
@dnplkndll dnplkndll changed the title [17.0][MIG] product_attribute_set [17.0][MIG] product_attribute_set: Migration to 17.0 Feb 5, 2025
@kobros-tech kobros-tech force-pushed the 17.0-MIG-product_attribute_set branch from f241137 to e6189b8 Compare February 6, 2025 17:57
@kobros-tech kobros-tech mentioned this pull request Feb 6, 2025
2 tasks
@kobros-tech kobros-tech force-pushed the 17.0-MIG-product_attribute_set branch from e6189b8 to 91f7326 Compare February 10, 2025 11:40
@kobros-tech kobros-tech force-pushed the 17.0-MIG-product_attribute_set branch from 91f7326 to 07360bd Compare February 11, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.