[MIG] stock_account_operating_unit: Migration to 17.0 #725
Conversation
Added Test Cases. Improved code for test cases Migrated Valuation method of quants. Migrated Valuation method _account_entry_move of quants. Completed test cases and modified valuation method
Currently translated at 100.0% (3 of 3 strings) Translation: operating-unit-13.0/operating-unit-13.0-stock_account_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-13-0/operating-unit-13-0-stock_account_operating_unit/es/
FIX test-requirements
…it is not longer required
BT-dherreros
force-pushed
the
17.0-mig-stock-account-operating-unit
branch
from
e6fc13f to
fb9abce
Compare
| @@ -0,0 +1,2 @@ | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | |||
BT-dherreros
force-pushed
the
17.0-mig-stock-account-operating-unit
branch
from
fb9abce to
3938389
Compare
|
This PR has the |
I had another functional look at this code and it seems to be creating 2 journal entries, one that seems to be correct and comes form Odoo's core and the other one coming from this migrated module with an incorrect ref field. Could you confirm this? maybe this migration is not needed anymore |
There was a problem hiding this comment.
Yes. I think it is a past improvement done in a previous version:
Create stock moves between internal locations within the same company, but
different OU’s. The journal entries are created and they are self-balanced
within the OU when the journal entries are posted
This may be creating double JE when the products are actually moved out of the company. In my opinion, it is best to remove the action_done method, or at least, check if the products are move between internal locations of different OUs for doing the change.
I've some issues with moving products between different OU. That is why I have forbidden this action in my instances and I force to move first out of the company from OU1 and then move into the company using OU2. So, I am ok with removing the overwrite in the action_done method of stock.move
No description provided.