Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] stock_lot_is_archived #1275

Merged
merged 2 commits into from
Apr 15, 2024
Merged

[ADD] stock_lot_is_archived #1275

merged 2 commits into from
Apr 15, 2024

Conversation

rousseldenis
Copy link
Contributor

No description provided.

@rousseldenis rousseldenis added this to the 16.0 milestone Feb 23, 2023
@rousseldenis rousseldenis force-pushed the 16.0-add-product_lot_archived-dro branch from d9e57de to fa0028a Compare February 23, 2023 10:20
@rousseldenis rousseldenis marked this pull request as draft March 17, 2023 10:55
@rousseldenis rousseldenis force-pushed the 16.0-add-product_lot_archived-dro branch 2 times, most recently from 4c42c43 to 067626e Compare March 20, 2023 08:21
@rousseldenis rousseldenis changed the title [ADD] stock_production_lot_is_archived [ADD] stock_lot_is_archived Mar 20, 2023
@rousseldenis rousseldenis force-pushed the 16.0-add-product_lot_archived-dro branch from 067626e to 97187f0 Compare March 20, 2023 08:23
@rousseldenis rousseldenis marked this pull request as ready for review March 20, 2023 08:23
aliciagaarzo
aliciagaarzo reviewed Apr 19, 2023
View reviewed changes
Copy link

@aliciagaarzo aliciagaarzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you change the tests to cover all cases?

@rousseldenis
Copy link
Contributor Author

Hi, could you change the tests to cover all cases?

@aliciagaarzo Done. Thanks for the review

hugo-cordoba
hugo-cordoba approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@hugo-cordoba hugo-cordoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review)

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 27, 2023
@github-actions github-actions bot closed this Oct 1, 2023
@lmignon
Copy link
Contributor

lmignon commented Feb 22, 2024

@rousseldenis Can you reopen and merge this one?

@rousseldenis rousseldenis reopened this Apr 15, 2024
@rousseldenis
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1275-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e538b6e into OCA:16.0 Apr 15, 2024
7 of 8 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4c5b6a9. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-add-product_lot_archived-dro branch April 15, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugo-cordoba hugo-cordoba hugo-cordoba approved these changes

@aliciagaarzo aliciagaarzo aliciagaarzo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rousseldenis @lmignon @OCA-git-bot @aliciagaarzo @hugo-cordoba