-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] product_internal_reference_generator #1453
[ADD] product_internal_reference_generator #1453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving my review over from OCA/product-variant#309
Code review, LGTM!
Module is incompatible with product_sequence. Is there a way to specify incompatibility? |
There are two steps you need to take:
|
daee95c
to
68bc34a
Compare
Make sure to also push the new |
There was too many questions from copier after copier recopy and lots of files changed. So i just copied only tests yml. I dont think my new answers file was correct. |
Aside from the one question that I took a screenshot of, you don't have to change any of the other answers. if you don't commit the |
5dc039c
to
3d0634f
Compare
@ilyasProgrammer why don't you change copier in a separate PR so it gets merged straight away? |
3d0634f
to
f406b5d
Compare
Problem not in copier, but in modules conflicts. |
But looks like need to update copier as well |
@ilyasProgrammer copier files should be removed from here I think |
f406b5d
to
6b65aed
Compare
rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review ok!
@pedrobaeza feedback? thanks!
6b65aed
to
04ba879
Compare
@pedrobaeza good to go? |
No, the change should be done in the copier template and should be reflected in the CI yaml, not manually edited the file |
04ba879
to
b028717
Compare
So what i did is: @pedrobaeza is it correct ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now it is correct
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at ca4cefe. Thanks a lot for contributing to OCA. ❤️ |
This module allows to generate internal references for Product templates and variants using sequences, setting codes as read-only.
In product template, it's possible to choose among different Internal Reference Templates related to a sequence, and then generate an internal reference with the following structure:
Internal Reference Prefix + progressive number for variant, eg: “Main0001001”, where:
"Main0001" is the prefix generated by sequence and assigned to product template, and
"001" the variant identifier.
Every time a new variant is created, a new internal reference is automatically assigned with progressive variant code.
A specific access rights allows specific users to change internal reference template for a product template once an internal reference has been generated, as well as editing existing ones.