[16.0][IMP]product_packaging_level: recover name_get policy flow

[sonhd91]

As suggested in: #1427 (comment)

No need to update _onchange_package_type so I keep it

[lmignon]

@sonhd91 A minor comment...

Since the name is mandatory and not translatable, to avoid mismatch according to the user language when the package level is created, you should maybe add an additional parameter to select the language to use to compute the name.

[sonhd91]

@sonhd91 A minor comment...

Since the name is mandatory and not translatable, to avoid mismatch according to the user language when the package level is created, you should maybe add an additional parameter to select the language to use to compute the name.

Hello @lmignon, the _get_name_from_policy calculates the name packaging by using the display_name which include language context for computation, so it will take the value in the user's language context at the packaging creation step

[simahawk]

@sonhd91 A minor comment...
Since the name is mandatory and not translatable, to avoid mismatch according to the user language when the package level is created, you should maybe add an additional parameter to select the language to use to compute the name.

Hello @lmignon, the _get_name_from_policy calculates the name packaging by using the display_name which include language context for computation, so it will take the value in the user's language context at the packaging creation step

yeah but then you should use @api.depends_context("lang") no? (even if only to document it)

[lmignon]

@sonhd91 A minor comment...
Since the name is mandatory and not translatable, to avoid mismatch according to the user language when the package level is created, you should maybe add an additional parameter to select the language to use to compute the name.

Hello @lmignon, the _get_name_from_policy calculates the name packaging by using the display_name which include language context for computation, so it will take the value in the user's language context at the packaging creation step

yeah but then you should use @api.depends_context("lang") no? (even if only to document it)

My main concern is to ensure to store into the database the value always in the same language..

[sonhd91]

@sonhd91 A minor comment...
Since the name is mandatory and not translatable, to avoid mismatch according to the user language when the package level is created, you should maybe add an additional parameter to select the language to use to compute the name.

Hello @lmignon, the _get_name_from_policy calculates the name packaging by using the display_name which include language context for computation, so it will take the value in the user's language context at the packaging creation step

yeah but then you should use @api.depends_context("lang") no? (even if only to document it)

Hello, I just updated the branch please checked again

[cyrilmanuel]

@lmignon little ping, is it good for you ?

[simahawk]

/ocabot merge minor

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1527-by-simahawk-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at fd2aec3. Thanks a lot for contributing to OCA. ❤️