-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] product_attribute_value_price_formula #1531
base: 16.0
Are you sure you want to change the base?
[ADD] product_attribute_value_price_formula #1531
Conversation
e2a816c
to
d4b96a2
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
d4b96a2
to
bcd9785
Compare
Rebased on |
class ProductProduct(models.Model): | ||
_inherit = "product.product" | ||
|
||
ptav_formula_extra_price = fields.Float( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ptav_formula_extra_price = fields.Float( | |
product_template_attribute_value_formula_extra_price = fields.Float( |
Explicit is better than implicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a look!
I know, but ptav
looked like a familiar acronym to me since it's already used throughout Odoo's codebase, for instance https://github.com/odoo/odoo/blob/9e774cf88398b7ffc701c4adf44451e39963db08/addons/website_sale/tests/test_website_sale_reorder_from_portal.py#L45-L47
ptavs = no_variant_template.attribute_line_ids.product_template_value_ids
ptav_s = ptavs.filtered(lambda ptav: ptav.product_attribute_value_id == s)
ptav_l = ptavs.filtered(lambda ptav: ptav.product_attribute_value_id == l)
Anyhow, I changed it
bcd9785
to
458d02e
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
No description provided.