Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] product_attribute_value_price_formula #1531

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

SirAionTech
Copy link

No description provided.

@SirAionTech SirAionTech marked this pull request as ready for review February 29, 2024 14:34
@SirAionTech SirAionTech force-pushed the 16.0-add-product_attribute_value_price_formula branch 2 times, most recently from e2a816c to d4b96a2 Compare April 2, 2024 09:27
Copy link

github-actions bot commented Aug 4, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 4, 2024
@SirAionTech SirAionTech force-pushed the 16.0-add-product_attribute_value_price_formula branch from d4b96a2 to bcd9785 Compare August 5, 2024 07:10
@SirAionTech
Copy link
Author

Rebased on 16.0.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
@rousseldenis rousseldenis added this to the 16.0 milestone Sep 23, 2024
class ProductProduct(models.Model):
_inherit = "product.product"

ptav_formula_extra_price = fields.Float(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ptav_formula_extra_price = fields.Float(
product_template_attribute_value_formula_extra_price = fields.Float(

Explicit is better than implicit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look!
I know, but ptav looked like a familiar acronym to me since it's already used throughout Odoo's codebase, for instance https://github.com/odoo/odoo/blob/9e774cf88398b7ffc701c4adf44451e39963db08/addons/website_sale/tests/test_website_sale_reorder_from_portal.py#L45-L47

        ptavs = no_variant_template.attribute_line_ids.product_template_value_ids
        ptav_s = ptavs.filtered(lambda ptav: ptav.product_attribute_value_id == s)
        ptav_l = ptavs.filtered(lambda ptav: ptav.product_attribute_value_id == l)

Anyhow, I changed it

@SirAionTech SirAionTech force-pushed the 16.0-add-product_attribute_value_price_formula branch from bcd9785 to 458d02e Compare September 27, 2024 13:23
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants