-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] product_variant_attribute_name_manager: more precise explanation #1555
base: 16.0
Are you sure you want to change the base?
Conversation
Hi @JordiMForgeFlow, |
@zeroheure thank you for the proposal. Could you change the commit message following the guidelines here (https://github.com/OCA/odoo-community.org/blob/8afdb5a5ebfd3314e2fc836c9b9f644468ee044e/website/Contribution/CONTRIBUTING.rst#L1114)? You mainly need to add '[IMP] product_variant_attribute_name_manager: ...'. Also, pre-commit check is not passing, if you could also look into that :) |
lines lesser than 88 characters
remove trailing spaces in __manifest__.py
@JordiMForgeFlow should be ok but there is still a pre-commit error that I don't understand |
@zeroheure I can see that there are 3 commits all with wrong commit message. You should only have one commit with a message like "[IMP] product_variant_attribute_name_manager: more precise module summary". The pre-commit is complaining about some trailing whitespace. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
this commit improve module description, helping to understand that it is only for back office