Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] product_variant_attribute_name_manager: more precise explanation #1555

Open
wants to merge 3 commits into
base: 16.0
Choose a base branch
from

Conversation

zeroheure
Copy link
Contributor

@zeroheure zeroheure commented Mar 15, 2024

this commit improve module description, helping to understand that it is only for back office

@OCA-git-bot
Copy link
Contributor

Hi @JordiMForgeFlow,
some modules you are maintaining are being modified, check this out!

@JordiMForgeFlow
Copy link
Contributor

@zeroheure thank you for the proposal. Could you change the commit message following the guidelines here (https://github.com/OCA/odoo-community.org/blob/8afdb5a5ebfd3314e2fc836c9b9f644468ee044e/website/Contribution/CONTRIBUTING.rst#L1114)? You mainly need to add '[IMP] product_variant_attribute_name_manager: ...'.

Also, pre-commit check is not passing, if you could also look into that :)

@zeroheure zeroheure changed the title more precise explanation [IMP] more precise explanation Jun 3, 2024
@zeroheure zeroheure changed the title [IMP] more precise explanation [IMP] product_variant_attribute_name_manager: more precise explanation Jun 3, 2024
zeroheure added 2 commits June 3, 2024 10:47
lines lesser than 88 characters
remove trailing spaces in __manifest__.py
@zeroheure
Copy link
Contributor Author

@JordiMForgeFlow should be ok but there is still a pre-commit error that I don't understand

@JordiMForgeFlow
Copy link
Contributor

@zeroheure I can see that there are 3 commits all with wrong commit message. You should only have one commit with a message like "[IMP] product_variant_attribute_name_manager: more precise module summary".

The pre-commit is complaining about some trailing whitespace.

@rousseldenis
Copy link
Contributor

@zeroheure

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants