Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] product_template_tags: use tags on both templates and variants #1562

Closed
wants to merge 2 commits into from

Conversation

SilvioC2C
Copy link
Contributor

This commit allows using tags on both templates and variants.

Tags can be propagated on each template-variants couple in 2 ways:

  • from template to variants: in this case, templates tags are copied onto every variant
  • from variants to template: in this case, the template inherits all the variants' tags

The propagation behavior is defined at template's level. Default propagation behavior is "from template to variants" to allow full retrocompatibility with module's previous workflow.

This commit allows using tags on both templates and variants.

Tags can be propagated on each template-variants couple in 2 ways:
- from template to variants: in this case, templates tags are copied onto every variant
- from variants to template: in this case, the template inherits all the variants' tags

The propagation behavior is defined at template's level. Default propagation behavior is
 "from template to variants" to allow full retrocompatibility with module's previous workflow.
@OCA-git-bot
Copy link
Contributor

Hi @ivantodorovich, @patrickrwilson,
some modules you are maintaining are being modified, check this out!

@SilvioC2C SilvioC2C force-pushed the IMP-product_template_tags branch from ee1b4ee to 710b13f Compare March 21, 2024 10:27
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have a very simple new module that plays only w/ variants.
I don't think there's the need to customize the behavior by template.
If you manage tags at variant level, it's for all products.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@github-actions github-actions bot closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants