Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] product_print_category print report name #1571

Conversation

nayatec
Copy link
Contributor

@nayatec nayatec commented Apr 3, 2024

@legalsylvain Hello, the print_report_name must be a python valid expression, can you check this fix ?

@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !
fast tracking this trivial patch.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1571-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 4, 2024
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1571-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@legalsylvain
Copy link
Contributor

Could you rebase @nayatec ?

@nayatec nayatec force-pushed the 16.0-fix-product_print_category_print_report_name branch 2 times, most recently from 867d688 to f8c7d08 Compare April 8, 2024 07:49
@nayatec
Copy link
Contributor Author

nayatec commented Apr 8, 2024

@legalsylvain done, and fixed a trivial mistake i made...

@nayatec nayatec force-pushed the 16.0-fix-product_print_category_print_report_name branch from f8c7d08 to 66e40c4 Compare April 8, 2024 07:56
@legalsylvain
Copy link
Contributor

/ocabot merge patch

thanks !

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1571-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 8, 2024
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1571-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@nayatec
Copy link
Contributor Author

nayatec commented Apr 16, 2024

@legalsylvain should be ok now, there was a backslash unescaped in the fr.po file, the click-odoo-makepot runs ok against it now in my local dev

@legalsylvain
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1571-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit af7fb6b into OCA:16.0 Apr 16, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at badad10. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants