[16.0][MIG] product_code_mandatory #1575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] Module to set the internal reference of the product as required.
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_code_mandatory/pt/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr_FR/
Currently translated at 100.0% (2 of 2 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/it/
|
LGTM Functional +1 @agyamuta @pedrocasi |
|
Hey @mariobinhex could you squash migration commits? |
Move setUp test class to setUpClass for better performant [ADD] product_code_mandatory: Add contributors [IMP] product_cost_security: clarify product cost edit required permissions As seen in OCA/margin-analysis#198 (review), a user needs some other group that grants them permissions for editing products, apart from this one that allows them to edit product cost. This might not seem obvious to the user, so it's better to document it. Btw, I renamed the groups to be shorter. Still easy to understand, now that groups are grouped (🥁). @moduon MT-5158 [UPD] Update product_cost_security.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_cost_security Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_cost_security/
MarioLM-23
force-pushed
the
16.0-mig-product_code_mandatory
branch
from
bdccb55 to
e0aa2d2
Compare
Done! I have maintained the pre-commit and migration |
|
@OCA/product-maintainers could you please merge? |
|
@rafaelbn Hello Rafal, can you please check this PR? |
|
@rafaelbn hi Rafael, can you please check this PR and merge? |
|
@simahawk hi Simone, can you please check this PR and merge? Thank you! |
simahawk
requested changes
Jul 18, 2024
| return self.env["ir.sequence"].next_by_code("product.default.code") | ||
|
|
||
| default_code = fields.Char( | ||
| "Internal Reference", index=True, default=_get_default_code |
There was a problem hiding this comment.
Suggested change
| "Internal Reference", index=True, default=_get_default_code | |
| "Internal Reference", index=True, default=lambda self: self._get_default_code() |
To be done in a separated commit that can be back/fwd ported
Comment on lines
+3
to
+6
| from odoo.tests.common import TransactionCase | ||
|
|
||
|
|
||
| class TestProductCode(TransactionCase): |
There was a problem hiding this comment.
Suggested change
| from odoo.tests.common import TransactionCase | |
| class TestProductCode(TransactionCase): | |
| from odoo.tests.common import BaseCommon | |
| class TestProductCode(BaseCommon): |
to disable tracking
|
/ocabot migration product_code_mandatory |
|
Hi @MarioLM-23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve test classes with setUpClass.
Last PR closed of migration module: #1237.
Checked two last issues.