Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] product_pricelist_alternative: validate alternative pricelist with based formula pricelist #1576

Conversation

santostelmo
Copy link
Contributor

Validate the following:
Formulas based on another pricelist are not allowed on alternative pricelists.

@santostelmo santostelmo changed the title [IMP] product_pricelist_alternative: validate alternative pricelist with based formula pricelist [16.0][IMP] product_pricelist_alternative: validate alternative pricelist with based formula pricelist Apr 10, 2024
Copy link

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ajaniszewska-dev ajaniszewska-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to rebase

Copy link
Contributor

@SilvioC2C SilvioC2C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only 1 nitpicking and non-blocking comment

@santostelmo santostelmo force-pushed the 16.0-imp-product_pricelist_alternative-validation-constraint branch 2 times, most recently from 6a349f9 to a913613 Compare October 10, 2024 13:29
@santostelmo santostelmo force-pushed the 16.0-imp-product_pricelist_alternative-validation-constraint branch from a913613 to c47ca22 Compare October 10, 2024 13:49
@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1576-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5706835 into OCA:16.0 Oct 10, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7e2c713. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants