Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] product_packaging_level: Rely on 'qty' field too to compute the qty_per_level field #1595

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[IMP] product_packaging_level: Rely on 'qty' field too to compute the qty_per_level field #1595

wants to merge 1 commit into from

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis commented Apr 29, 2024 •
edited
Loading

In the product packaging Form view, rely also on 'qty' field to have a coherent behaviour for the display of qty_per_level field.

In that case, self.id == NewId, so compare ids field instead which is always a list of integers.

@rousseldenis rousseldenis changed the title [IMP] product_packaging_level: Rely on 'qty' field too to compute the… [IMP] product_packaging_level: Rely on 'qty' field too to compute the qty_per_level field Apr 29, 2024
@rousseldenis rousseldenis added this to the 16.0 milestone Apr 29, 2024
@rousseldenis
Copy link
Contributor Author

@jbaudoux

jbaudoux
jbaudoux approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@rousseldenis
[IMP] product_packaging_level: Rely on 'qty' field too to compute the…
fdfc72b 
… qty_per_level field

In the product packaging Form view, rely also on 'qty' field to have a coherent behaviour
for the display of qty_per_level field.

In that case, self.id == NewId, so compare ids field instead which is always a list of integers.
@rousseldenis rousseldenis force-pushed the 16.0-imp-package_level-dro branch from 4669a77 to fdfc72b Compare May 6, 2024 12:27
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@jbaudoux
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @jbaudoux you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved enhancement needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rousseldenis @OCA-git-bot @jbaudoux @FrancoMaxime