[15.0][FIX] base_product_mass_addition: _complete_quick_line_vals function. #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luis-ron
approved these changes
May 23, 2024
HaraldPanten
approved these changes
May 23, 2024
|
This PR has the |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 50e3e48. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the
_complete_quick_line_vals()function that causes incorrect operation when lines are added with the purchase_quick wizard with the same discount as in the first line.To reproduce the bug:
Create a purchase quotation.
Use the purchase wizard to add a product with one or more discounts -> The line is generated correctly:
Now add another line with the same discount values as line 1 -> The discounts are not added:
More details:
When the
_complete_quick_line_vals()function of the ProductMassAddition model of the base_product_mass_addition module has more than one line, the line that makes the call to theplay_onchanges()function of the onchange_helper module is the first one.https://github.com/OCA/product-attribute/blob/5dd6892879d238330d191cd9b8a16f94cd26b15f/base_product_mass_addition/models/product_mass_addition.py#L71C1-L72C32
This causes the onchange of the discounts not to be executed, since the value coming to it through line 1 is the same as the value of the line being created.
Proposed solution
Create an empty
lines_keyrecord and have this be the one to call theonchange_helper()function.To test this PR -> PR OCA/purchase-workflow#2265 with the reference to this PR
[T-5877]