Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [MIG] product_print_category #1607

Merged
merged 25 commits into from
Aug 30, 2024

Conversation

MarioLM-23
Copy link

@MarioLM-23 MarioLM-23 commented May 6, 2024

Standar migration with changes in views, readme images and improve test

legalsylvain and others added 24 commits May 6, 2024 09:50
…product and allow to print various format of labels
…d avoid checkbox to be checked during the save of the product.

[REF] make the module working if a create is done directly on product.template
…e better default print category values.

[REM] remove default_print_category on res.company model
…roup, because it make the default computation failing on the product.product form view if user is not member of the group. Also to align with the rest of odoo : print_category_id is a regular field that can be user by any user that is member of base.group_user as all the other field

[FIX] use _for_xml_id to avoid error if user is not admin, when using the print wizard
[REF] use expression.AND to simplify code
Currently translated at 100.0% (54 of 54 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_print_category
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_print_category/it/
Currently translated at 100.0% (54 of 54 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_print_category
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_print_category/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_print_category
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_print_category/
@MarioLM-23 MarioLM-23 mentioned this pull request May 6, 2024
63 tasks
@MarioLM-23 MarioLM-23 force-pushed the 17.0-mig-product_print_category branch from 11970a3 to f33a2a2 Compare May 6, 2024 11:44
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for porting this module @mariobinhex.

Suggestion inline. Otherwise, LGTM. Thanks !

[IMP] product_print_category: Improve test and add contributors

[FIX] product_print_category: Fix view
@MarioLM-23 MarioLM-23 force-pushed the 17.0-mig-product_print_category branch from f33a2a2 to a79ac80 Compare May 6, 2024 13:54
@MarioLM-23
Copy link
Author

@legalsylvain Done! Sorry for that mistake

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legalsylvain Done! Sorry for that mistake

No problem.

@dreispt
Copy link
Member

dreispt commented Aug 30, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1607-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8d9ec7d into OCA:17.0 Aug 30, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7de9f7b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants