Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] product_attachment_zipped_download: Migration to 16.0 #1822

Merged
merged 3 commits into from
Jan 16, 2025
Merged

[16.0][MIG] product_attachment_zipped_download: Migration to 16.0 #1822

merged 3 commits into from
Jan 16, 2025

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Dec 18, 2024 •
edited
Loading

Migration to 16.0

Please @pedrobaeza and @sergio-teruel can you review it?

@Tecnativa TT52271

@pedrobaeza
Copy link
Member

/ocabot migration product_attachment_zipped_download

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 18, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 18, 2024
Open
58 tasks
@victoralmau victoralmau force-pushed the 16.0-mig-product_attachment_zipped_download branch from 3a24571 to 251344f Compare December 18, 2024 15:19
@pedrobaeza
Copy link
Member

/ocabot migration product_attachment_zipped_download

@victoralmau
[ADD] product_attachment_zipped_download: New module
fbc2378 
TT48578

[UPD] Update product_attachment_zipped_download.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-15.0/product-attribute-15.0-product_attachment_zipped_download
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_attachment_zipped_download/
@victoralmau
[IMP] product_attachment_zipped_download: pre-commit stuff
ea831d8
@victoralmau victoralmau force-pushed the 16.0-mig-product_attachment_zipped_download branch from 251344f to 5351da3 Compare January 7, 2025 08:04
@sergio-teruel
Copy link
Contributor

Well...
Only one question...

The link only is available in list view, if I access to form product I can't download the attachments, Is posible has it in form view too??

@victoralmau victoralmau force-pushed the 16.0-mig-product_attachment_zipped_download branch from 5351da3 to 843275b Compare January 14, 2025 12:25
@sergio-teruel
Copy link
Contributor

Great!! Thanks

@victoralmau
Copy link
Member Author

Please @sergio-teruel could you review and approve to be able to merge it?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1822-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1f8e867 into OCA:16.0 Jan 16, 2025
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2a65231. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-product_attachment_zipped_download branch January 16, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@victoralmau @pedrobaeza @sergio-teruel @OCA-git-bot @marcelsavegnago