[MIG] product_pricelist_supplierinfo: Migration to 18.0 #1837

CLaurelB · 2025-01-07T22:55:04Z

Supersed #1745

* Don't depend on sales * Extended README * Tests focused on module specific features * Code optimization * Don't mix pricelist info with supplier info on criteria

Date order is passed by context, so we have to take this into account for computing properly available supplierinfo records.

If not, you can twist the order in the form and rules won't be applied according criteria

If you set the value "Based on" for using supplier info, but then you change the computation type to another one (like fixed price or discount), this code is still acting, so we should check both fields.

OCA#436) Previously, only worked fine with product.product.

Currently translated at 93.3% (14 of 15 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_pricelist_supplierinfo/es/

When having price per qty at the supplier level and if you want to base your pricelist on the supplier price, now you can define a margin on the product.supplierinfo

Use standard way to select the seller. As a result a bug in previous solution is fixed also: before this, all supplierinfo records having product_tmpl_id set, were considered as possible price for all product variants, even if product_id was set also. That resulted in same price for all variants even if supplierinfo records had different price for all variants.

…t prices from

If we have suppliers in two or more currencies, and we have a pricelist with an item that is selected the "Prices based on supplier info" option but the pricelist is in a currency different from the supplierinfo the compute of the price get the price on the same amount but with a different currency. With these changes, we are converting the price to the currency on the pricelist that is being used. Also, a test was added to prove the previous behaviour.

Currently translated at 100.0% (20 of 20 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_pricelist_supplierinfo/fr/

It is possible that this method is called on an inactive template, in which case product_variant_id returns empty recordset and _select_seller will raise expected singleton error.

If we have a product with a supplier with a UOM "A" but the product is sold with a UOM "B" the price we are getting is the same no matter the UOM. For example: Product with the price 1200 per Dozen and we sell a 1 unit we are getting the price of 1200 for that unit when we should be obtaining 100. With these changes, we are converting the price to the UOM that is being used on the sale or the default on the product. Also, a test was added to prove the previous behaviour.

[UPD] Update product_pricelist_supplierinfo.pot [UPD] README.rst

… when date is datetime. date may come from context

When we check the price of any product, the date that we pass on the context has to be a Datetime value or None. With this change we avoid to pass a False. Here you have the reference to the code that check that https://github.com/OCA/OCB/blob/13.0/addons/product/models/product.py#L599-L600 TT29935 product_pricelist_supplierinfo 13.0.1.0.2

TT31816 [UPD] Update product_pricelist_supplierinfo.pot [UPD] README.rst [IMP] update dotfiles [ci skip]

In the e-commerce, if we have a pricelist with a rule based on supplierinfo for a determined supplier partner, such partner could be not accesible for public users and the affected products could not be reached. TT31476

If we don't have a supplierinfo that below 1 unit we won't get any seller. We want to ensure that the condition is fully ignored to get whatever price given the other criterias. TT33659

…sers 0581b66 is not enough on v13 for avoiding the access error, so we sudoed the whole price fetch operation. TT36898

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_supplierinfo/

Currently translated at 100.0% (14 of 14 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_supplierinfo/es/

Currently translated at 100.0% (14 of 14 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_supplierinfo/pt_BR/

Currently translated at 100.0% (14 of 14 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_supplierinfo/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-17.0/product-attribute-17.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_pricelist_supplierinfo/

Currently translated at 100.0% (14 of 14 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_pricelist_supplierinfo/it/

Update the sale margin string on the field to match the format of the discount field [1], which is located beside it in the list view. [1]: https://github.com/odoo/odoo/blob/e947c589/addons/product/models/product_supplierinfo.py#L65

…in price Introduce a new field to optionally exclude the discount set in the product supplier info when calculating the product's price. Additionally, add a test to validate the new functionality.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-17.0/product-attribute-17.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_pricelist_supplierinfo/

CLaurelB · 2025-01-08T00:26:07Z

Hello @luisg123v @pedrobaeza @florian-dacosta

Could you please review this PR?

It already includes the implementation of the two comments from #1745, which were merged in 17.0 here: #1836.

Best regards.

luisg123v · 2025-01-16T15:36:44Z

product_pricelist_supplierinfo/i18n/it.po

+#. module: product_pricelist_supplierinfo
+#: model:ir.model.fields,field_description:product_pricelist_supplierinfo.field_product_pricelist_item__no_supplierinfo_discount
+msgid "Ignore Supplier Info Discount"
+msgstr ""


Missing commit 7217428

luisg123v · 2025-01-16T15:38:16Z

product_pricelist_supplierinfo/security/res_groups.xml

@@ -1,9 +1,7 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <odoo>
-


Is this done by precommit? :(

luisg123v · 2025-01-16T15:40:08Z

product_pricelist_supplierinfo/README.rst

@@ -17,13 +17,13 @@ Supplier info prices in sales pricelists
    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
    :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github
-    :target: https://github.com/OCA/product-attribute/tree/17.0/product_pricelist_supplierinfo
+    :target: https://github.com/OCA/product-attribute/tree/18.0/product_pricelist_supplierinfo


This is part of the precommit autofixes, hence it should be in that commit.

Same for other autoformatting changes.

This is not done by the precommit autofixes.

luisg123v · 2025-01-16T15:41:06Z

product_pricelist_supplierinfo/models/product_template.py

@@ -27,7 +27,7 @@ def _get_supplierinfo_pricelist_price(
        # The product_variant_id returns empty recordset if template is not
        # active, so we must ensure variant exists or _select_seller fails.
        if product:
-            if type(date) == datetime:
+            if type(date) is datetime:


Why not isinstance here?

Updated to use isinstance.

luisg123v · 2025-01-16T15:43:16Z

product_pricelist_supplierinfo/tests/test_product_supplierinfo.py

-            )
-        else:
-            currency_rate.write({"rate": rate})
+    def _create_rate(cls, currency_id, rate):


Since we're modifying the whole method, let's fix currency_id → currency

luisg123v · 2025-01-16T15:44:23Z

product_pricelist_supplierinfo/tests/test_product_supplierinfo.py

-        else:
-            currency_rate.write({"rate": rate})
+    def _create_rate(cls, currency_id, rate):
+        cls.env["res.currency.rate"].create(


Since we don't know what rates are currently loaded, tests usually remove all existing records before creating new ones.

Deleted existing rates before creating a new rate.

luisg123v · 2025-01-16T15:46:27Z

product_pricelist_supplierinfo/tests/test_product_supplierinfo.py

+        )
+        self.assertAlmostEqual(price, 0)
+
+        product_template.product_variant_ids = False


This shouldn't be possible

Currently translated at 100.0% (15 of 15 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_pricelist_supplierinfo/it/

Changelog: - Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks. - Add a test for the scenario where the pricelist is not based on the supplier info, ensuring the price is calculated as expected natively. - Add a test for the scenario where there are no sellers linked to the product. - Replace the currency rate update by a currency rate creation in the tests, as demo rates have a fixed rate in the past. Co-authored-by: mle <[email protected]>

cubells and others added 30 commits January 7, 2025 22:46

product_pricelist_supplierinfo: priceslists based in supplier info

5120ee0

product_pricelist_supplierinfo: Several enhancements + concept fixing

fff23f2

* Don't depend on sales * Extended README * Tests focused on module specific features * Code optimization * Don't mix pricelist info with supplier info on criteria

product_pricelist_supplierinfo: Take into account sales order date

c249964

Date order is passed by context, so we have to take this into account for computing properly available supplierinfo records.

product_pricelist_supplierinfo: Give more priority in order to min_qty

a457369

If not, you can twist the order in the form and rules won't be applied according criteria

[MIG] product_pricelist_supplierinfo v11 to v12

e76b553

[FIX] product_pricelist_supplierinfo: Proper URL

58332fd

[FIX] product_pricelist_supplierinfo: Avoid false computations

c989f0b

If you set the value "Based on" for using supplier info, but then you change the computation type to another one (like fixed price or discount), this code is still acting, so we should check both fields.

[11.0][FIX] product_pricelist_supplierinfo: Add template compatibility (

412afad

OCA#436) Previously, only worked fine with product.product.

Added translation using Weblate (Italian)

dabbeea

Added translation using Weblate (Portuguese (Brazil))

1426bc9

[IMP] add margin on supplier info to configure the sale price

68460e6

When having price per qty at the supplier level and if you want to base your pricelist on the supplier price, now you can define a margin on the product.supplierinfo

IMP product_pricelist_supplierinfo allowing to filter suppliers to ge…

338063c

…t prices from

Added translation using Weblate (French)

30d353f

[FIX] product_pricelist_supplierinfo: ensure product exists

cfc3477

It is possible that this method is called on an inactive template, in which case product_variant_id returns empty recordset and _select_seller will raise expected singleton error.

Added translation using Weblate (Dutch)

abe10bd

Added translation using Weblate (Catalan)

1eb4389

[IMP] product_pricelist_supplierinfo: black, isort

dbf4f63

[MIG] product_pricelist_supplierinfo: Migration to v13.0

a718c1c

[UPD] Update product_pricelist_supplierinfo.pot [UPD] README.rst

FIX product_pricelist_supplierinfo: _get_supplierinfo_pricelist_price…

588e274

… when date is datetime. date may come from context

[IMP] product_pricelist_supplierinfo: black, isort, prettier

91fd8ed

[MIG] product_pricelist_supplierinfo: Migration to 14.0

36f814e

TT31816 [UPD] Update product_pricelist_supplierinfo.pot [UPD] README.rst [IMP] update dotfiles [ci skip]

[FIX] product_pricelist_supplierinfo: public users

c2ad1a4

In the e-commerce, if we have a pricelist with a rule based on supplierinfo for a determined supplier partner, such partner could be not accesible for public users and the affected products could not be reached. TT31476

[FIX] product_pricelist_supplierinfo: override min quantity

0a953af

If we don't have a supplierinfo that below 1 unit we won't get any seller. We want to ensure that the condition is fully ignored to get whatever price given the other criterias. TT33659

[FIX] product_pricelist_supplierinfo: Allow to show shop for public u…

070735f

…sers 0581b66 is not enough on v13 for avoiding the access error, so we sudoed the whole price fetch operation. TT36898

oca-ci and others added 18 commits January 7, 2025 22:46

[UPD] Update product_pricelist_supplierinfo.pot

5591a10

product_pricelist_supplierinfo 16.0.1.0.1

3c11293

[UPD] README.rst

0c0cd94

[IMP] product_pricelist_supplierinfo: pre-commit auto fixes

10ee467

[MIG] product_pricelist_supplierinfo: Migration to 17.0

0492ab2

[UPD] Update product_pricelist_supplierinfo.pot

7296a24

[BOT] post-merge updates

fee3611

[IMP] product_pricelist_supplierinfo: exclude supplier info discount …

29ad8f2

…in price Introduce a new field to optionally exclude the discount set in the product supplier info when calculating the product's price. Additionally, add a test to validate the new functionality.

[UPD] Update product_pricelist_supplierinfo.pot

4a9fed0

[BOT] post-merge updates

bd8c1bf

CLaurelB force-pushed the 18.0-mig-product_pricelist_supplierinfo-CLaurelB branch from 4fc6bf7 to abbc972 Compare January 8, 2025 00:21

desdelinux approved these changes Jan 12, 2025

View reviewed changes

CLaurelB force-pushed the 18.0-mig-product_pricelist_supplierinfo-CLaurelB branch 3 times, most recently from 25e8f5a to 0f1a8e9 Compare January 13, 2025 22:52

luisg123v suggested changes Jan 16, 2025

View reviewed changes

mymage and others added 3 commits January 16, 2025 22:07

[IMP] product_pricelist_supplierinfo: pre-commit auto fixes

239722a

CLaurelB force-pushed the 18.0-mig-product_pricelist_supplierinfo-CLaurelB branch from 0f1a8e9 to f35fd64 Compare January 16, 2025 23:15

CLaurelB requested a review from luisg123v January 16, 2025 23:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] product_pricelist_supplierinfo: Migration to 18.0 #1837

[MIG] product_pricelist_supplierinfo: Migration to 18.0 #1837

CLaurelB commented Jan 7, 2025 •

edited

Loading

CLaurelB commented Jan 8, 2025

luisg123v Jan 16, 2025

CLaurelB Jan 16, 2025

luisg123v Jan 16, 2025

CLaurelB Jan 16, 2025

luisg123v Jan 16, 2025

CLaurelB Jan 16, 2025

luisg123v Jan 16, 2025

CLaurelB Jan 16, 2025

luisg123v Jan 16, 2025

CLaurelB Jan 16, 2025

luisg123v Jan 16, 2025

CLaurelB Jan 16, 2025

luisg123v Jan 16, 2025

CLaurelB Jan 16, 2025

		@@ -1,9 +1,7 @@
		<?xml version="1.0" encoding="UTF-8" ?>
		<odoo>

[MIG] product_pricelist_supplierinfo: Migration to 18.0 #1837

Are you sure you want to change the base?

[MIG] product_pricelist_supplierinfo: Migration to 18.0 #1837

Conversation

CLaurelB commented Jan 7, 2025 • edited Loading

CLaurelB commented Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLaurelB commented Jan 7, 2025 •

edited

Loading