-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][mig] project_deadline: Migration to 16.0 #1351
base: 16.0
Are you sure you want to change the base?
Conversation
@heliaktiv , I have reopened PR of migrating project_deadline to 16.0 and I would request you to review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review: LGTM
Please squash administrative commits, as described here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate |
self.assertIn("date_start", res["arch"]) | ||
self.assertIn("date", res["arch"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why were these two lines changed to be the opposite of what they were before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of Odoo 16.0 addons project view, date_start and date fields are included in the xml whose external id is "edit_project" which is displayed as "Planned Date".
https://github.com/odoo/odoo/blob/16.0/addons/project/views/project_views.xml#L506C28-L511C119
As this is available as part of Odoo addons project module, I am removing project_project related code changes which appends date_start and date field to the form view from project_deadline module.
Also, the testcase related to it is also no longer valid for 16.0 version
I tried to squash the commit, but it resulted in merge conflict issue related to project_hr commits, so could not do it. When git rebase -i origin/16.0 is executed, it lists other project related repos like project_hr and showing merge conflicts related to hr project during squash Is there any way to get only project_deadline related commits alone, so that it can be squashed? |
I suspect your repo may be outdated. Can you try |
[FIX] Flake [ADD] Use fields_view_get [ADD] Use fields_view_get [ADD] Tests [FIX] Quick create form bug [ADD] usage description
133848f
to
d08d199
Compare
Currently translated at 80.0% (4 of 5 strings) Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/
Currently translated at 100.0% (8 of 8 strings) Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/es_AR/
Currently translated at 100.0% (8 of 8 strings) Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/it/
d08d199
to
b66b060
Compare
b66b060
to
a635b8a
Compare
Migrating project_deadline to 16.0
Reopened PR: #1123