Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] purchase_tier_validation: Migration to 18.0 #2447

Merged
merged 64 commits into from
Feb 12, 2025
Merged

[18.0][MIG] purchase_tier_validation: Migration to 18.0 #2447

merged 64 commits into from
Feb 12, 2025

Conversation

Quan-nhm
Copy link

@Quan-nhm Quan-nhm commented Nov 4, 2024

No description provided.

LoisRForgeFlow and others added 30 commits November 4, 2024 11:27
@LoisRForgeFlow @Quan-nhm
[9.0][ADD] purchase_tier_validation
03ccb58
@LoisRForgeFlow @Quan-nhm
[9.0][IMP] purchase_tier_validation:
e976762 
* able to restart validation process.
* view fixes.
@LoisRForgeFlow @Quan-nhm
[10.0][MIG] purchase_tier_validation
a84b96c
@LoisRForgeFlow @Quan-nhm
[11.0][MIG] purchase_tier_validation
087968b
@JordiBForgeFlow @Quan-nhm
- add support for field 'can_review' to hide the approve/reject buttons
b4640d7 
- add possibility to restart the validation at any point in time during the
approval process.
@oca-travis @Quan-nhm
[UPD] Update purchase_tier_validation.pot
e0b4095
@OCA-git-bot @Quan-nhm
[ADD] icon.png
667ebe9
@etobella @Quan-nhm
Added translation using Weblate (Spanish)
e629374
@JordiBForgeFlow @Quan-nhm
add the status 'to approve' to the initiating states to trigger the v…
188712a 
…alidation.
@etobella @Quan-nhm
fixup! add the status 'to approve' to the initiating states to trigge…
e8365f8 
…r the validation. (OCA#22)
@HviorForgeFlow @Quan-nhm
Move review view to button box
9806d17
@etobella @Quan-nhm
Translated using Weblate (Spanish)
74fdb87 
Currently translated at 100.0% (14 of 14 strings)

Translation: purchase-workflow-11.0/purchase-workflow-11.0-purchase_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-11-0/purchase-workflow-11-0-purchase_tier_validation/es/
@oca-travis @Quan-nhm
[UPD] Update purchase_tier_validation.pot
abe3086
@oca-transbot @Quan-nhm
Update translation files
003dc47 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-11.0/purchase-workflow-11.0-purchase_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-11-0/purchase-workflow-11-0-purchase_tier_validation/
@Quan-nhm
[MIG] purchase_tier_validation: Migration to 12.0
da8d209
@oca-travis @Quan-nhm
[UPD] Update purchase_tier_validation.pot
24f3d64
@oca-transbot @Quan-nhm
Update translation files
dfb7300 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_tier_validation/
@AdriaGForgeFlow @Quan-nhm
[12.0][FIX] purchase_tier_validation
d67b3bf
@liweijie0812 @Quan-nhm
Added translation using Weblate (Chinese (Simplified))
e230fc6
@pegonzalezspesol @Quan-nhm
[IMP] purchase_tier_validation: black, isort
f915559
@pegonzalezspesol @Quan-nhm
[MIG] 13.0 purchase_tier_validation
9f6a529
@oca-travis @Quan-nhm
[UPD] Update purchase_tier_validation.pot
c09f199
@OCA-git-bot @Quan-nhm
pre-commit update
dcc2673
@dong-z @Quan-nhm
Translated using Weblate (Chinese (Simplified))
033fa78 
Currently translated at 100.0% (13 of 13 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_tier_validation/zh_CN/
@yostashiro @Quan-nhm
[FIX] README.rst: runbot target
0dc3e4f
@MiquelRForgeFlow @Quan-nhm
[UPD] Eficent -> ForgeFlow
b8f1c68
@kittiu @Quan-nhm
[IMP] : black, isort, prettier
b669ebb
@kittiu @Quan-nhm
[14.0][MIG] purchase_tier_validation
98c99f9
@oca-travis @Quan-nhm
[UPD] Update purchase_tier_validation.pot
623ca1e
@OCA-git-bot @Quan-nhm
[UPD] README.rst
06c42e0
@mymage @Quan-nhm
Translated using Weblate (Italian)
e3862c3 
Currently translated at 100.0% (19 of 19 strings)

Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_tier_validation/it/
@Quan-nhm Quan-nhm mentioned this pull request Nov 4, 2024
Open
33 tasks
@StefanRijnhart StefanRijnhart reopened this Feb 4, 2025
@StefanRijnhart
Copy link
Member

/ocabot migration purchase_tier_validation

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 4, 2025
@StefanRijnhart StefanRijnhart reopened this Feb 4, 2025
StefanRijnhart
StefanRijnhart requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this test-requirements.txt to fix tests? https://github.com/OCA/purchase-workflow/blob/17.0/test-requirements.txt

@Quan-nhm
Copy link
Author

Quan-nhm commented Feb 7, 2025

Can you add this test-requirements.txt to fix tests? https://github.com/OCA/purchase-workflow/blob/17.0/test-requirements.txt

@StefanRijnhart , I got this error in the test. Do you know how to fix it?
image

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Feb 7, 2025 •
edited
Loading

Can you add this test-requirements.txt to fix tests? https://github.com/OCA/purchase-workflow/blob/17.0/test-requirements.txt

@StefanRijnhart , I got this error in the test. Do you know how to fix it?

You added a file test-requirements.txt in the module directory but it needs to go into the root of the repo.

@StefanRijnhart
Copy link
Member

Can you get rid of the merge commit?

@Quan-nhm
Copy link
Author

Quan-nhm commented Feb 7, 2025

Can you add this test-requirements.txt to fix tests? https://github.com/OCA/purchase-workflow/blob/17.0/test-requirements.txt

@StefanRijnhart , I got this error in the test. Do you know how to fix it?

You added a file test-requirements.txt in the module directory but it needs to go into the root of the repo.

Thank you, I just found it that I put it in wrong place. I just fixed it.

@Quan-nhm Quan-nhm force-pushed the 18.0-mig-purchase_tier_validation branch 2 times, most recently from 97ca636 to bcf04fc Compare February 7, 2025 11:13
@Quan-nhm
Copy link
Author

Quan-nhm commented Feb 7, 2025

Can you get rid of the merge commit?

@StefanRijnhart is this ok now?

StefanRijnhart
StefanRijnhart approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

celm1990
celm1990 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza changed the title [MIG] purchase_tier_validation: Migration to 18.0 [18.0][MIG] purchase_tier_validation: Migration to 18.0 Feb 12, 2025
@pedrobaeza
Copy link
Member

/ocabot migration purchase_tier_validation
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-2447-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8872755 into OCA:18.0 Feb 12, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4bf882c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@celm1990 celm1990 celm1990 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.