Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] manifest-behind-migrations: check manifest version >= migrations #475

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

antonag32
Copy link
Contributor

A new check has been added to verify that the migrations and manifest
version for a module are up to date.

Closes #461.

@antonag32 antonag32 marked this pull request as draft October 27, 2023 21:25
@antonag32
Copy link
Contributor Author

Draft as I need to functionally test this before merging.

@antonag32 antonag32 force-pushed the i461-anton branch 3 times, most recently from eec5659 to 252e915 Compare October 31, 2023 03:52
@antonag32 antonag32 marked this pull request as ready for review October 31, 2023 14:18
@antonag32 antonag32 requested a review from moylop260 October 31, 2023 14:18
@antonag32
Copy link
Contributor Author

Tested yesterday on the big four and seems to work fine. Just as a note, pre-commit-vauxoo only checks migration scripts above 14.0 so this check will only apply to codebases on Odoo 15 and up.

@moylop260
Copy link
Collaborator

@antonag32

Could you fix the lints, please?

A new check has been added to verify that the migrations and manifest
version for a module are up to date.

Closes OCA#461.
@antonag32
Copy link
Contributor Author

@antonag32

Could you fix the lints, please?

Done

@moylop260
Copy link
Collaborator

@luisg123v

Please, review

@luisg123v
Copy link
Contributor

@moylop260 could you set myself as a reviewer, please?

@moylop260
Copy link
Collaborator

@luisg123v
github doesn't allow me to choose you as reviewer :(

@moylop260 moylop260 merged commit 72f8714 into OCA:main Nov 17, 2023
15 checks passed
@moylop260 moylop260 deleted the i461-anton branch November 17, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure manifest version is not behind migration scripts
3 participants