Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][UPD] Forward port changes from 14.0 and 15.0 #729

Open
wants to merge 12 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][UPD] Forward port changes from 14.0 and 15.0 #729

wants to merge 12 commits into from

Conversation

florentx
Copy link
Contributor

@florentx florentx commented Dec 27, 2024 •
edited
Loading

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

sbidoul and others added 3 commits December 27, 2024 13:47
@sbidoul @florentx
Update test with proper way to pass company to job
2356167
@hhgabelgaard @florentx
[FIX] Access error on ir.attachment create
56fdd3e 
As normal user only have read access to delay.export, we need sudo to chreate an attachment on this record

Use user 6 (Marc Demo) in the tests, not admin (2)
@InigoGR @florentx
queue_job: fix retry format with tuple values
4ccc68e 
Configuration of randomized retry intervals is not possible due to the formatting checks not being updated.
This should fix it.
@florentx florentx changed the title [16.0][UPD] Forward port changes from 14.0 [16.0][UPD] Forward port changes from 14.0 and 15.0 Dec 27, 2024
@petrus-v @florentx
[FIX] queue_job_cron_jobrunner: use priority to select job
ca2a8c7 
* use FIFO, firt createad job will be treat first
* if priority are different it take the precedent

Yet we are not using channel priority into account
@florentx florentx mentioned this pull request Jan 13, 2025
Closed
@sebalix
Copy link
Contributor

sebalix commented Jan 13, 2025

You squashed commits from this PR into one: https://github.com/OCA/queue/pull/676/commits
History has to be preserved

sebalix
sebalix reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, LG othrewise

@florentx florentx force-pushed the 16.0_port branch 2 times, most recently from 2ebafe9 to 81ff27c Compare January 13, 2025 11:32
@florentx
Copy link
Contributor Author

I've re-based to preserve history here.
Fixes also s/flush/flush_model/

@sebalix
Copy link
Contributor

sebalix commented Jan 13, 2025

@florentx the flush call is still in ff52b57 while it should be in dbe64b9

@florentx
Copy link
Contributor Author

florentx commented Jan 13, 2025 •
edited
Loading

@florentx the flush call is still in ff52b57 while it should be in dbe64b9

I disagree, the flush was on the 2nd commit: 189a30761#diff-52052ee7edd7df6a68c13f1c6f9667c1556c7c08b0a8e91de76dcd7b2d604439R319

I preserved it.

The other flush in condition if state == DONE: was already present in branch 16.

EDIT: was also mentioned in comment on the PR that it pre-existed in 16: #676 (comment)

@sebalix
Copy link
Contributor

sebalix commented Jan 13, 2025

You are right, I misread the line, there is another flush call in the same method but regarding state == DONE, this one is already present in 16.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@florentx @OCA-git-bot @sebalix @sbidoul @hhgabelgaard @InigoGR @petrus-v @QuocDuong1306 @LoisRForgeFlow