[18.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 18.0 #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] Update queue_job_batch.pot
* incorrect sintax in security rule * change missleading name of security rule
standard migration and some little ux improvements: now hide button is a fa-check button that on click just marks as read the batch, do not navigate to it and updates immediately the systray.
* The batch enqueued method is removed, to better reflect the fact that the batch's jobs are executed immediately. * The batch state `draft` is is renamed to `pending`, for the same purpose. * The batch's `is_read` field is initialized as `False` (default value), and only set to `True` when it's actually read. * We now use `identity_exact` for the batch `check_state` delayed method. * The widget has been reimplemented due to the heavy refactoring made in the core `mail` app: odoo/odoo@7710c333
1 task
yankinmax
approved these changes
Jan 28, 2025
simahawk
approved these changes
Jan 28, 2025
|
|
||
| @api.depends("job_ids") | ||
| @api.depends("job_ids.state") |
There was a problem hiding this comment.
do we really need this depends? Job count is not stored.
There was a problem hiding this comment.
Not really, for the UI. I'd be necessary when reading the field programatically, though, without invalidating caches. It's a habit 😓
|
/ocabot migration queue_job_batch |
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds:
Changes:
draftis is renamed topending, for the same purpose.is_readfield is initialized asFalse(default value), and only set toTruewhen it's actually read.identity_exactfor the batchcheck_statedelayed method.mailapp: odoo/odoo@7710c333