Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Logistics: Release Channel, Reservation and Shopfloor repositories #66

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis commented Jan 24, 2025

@OCA/logistics-maintainers

Before first PR's creation in 18.0 repository and because modules amount in that field are quite important, I suggest to create a separate repository for release channel management.

See: https://github.com/OCA/wms

@rousseldenis rousseldenis force-pushed the add-18-release_channel-dro branch from ad47735 to ce96854 Compare January 24, 2025 11:46
@jbaudoux
Copy link
Contributor

What about dropping completely wms and reclassifying into:

  • stock-logistics-shopfloor : shopfloor* modules
  • stock-logistics-reservation : promise stuffs and reserve rule
  • stock-logistics-release-channel : release channel *
  • stock-logistics-workflow : dyn routing, batch creation, storage type, warehouse flow
  • delivery-carrier : delivery_carrier_warehouse (already merged, I was too quick..)

@sebalix
Copy link
Contributor

sebalix commented Jan 24, 2025

Good idea from @jbaudoux, it's a bit difficult to guess if a logistic module should land in wms or stock-logistics-* repo.

@rousseldenis
Copy link
Contributor Author

What about dropping completely wms and reclassifying into:

  • stock-logistics-shopfloor : shopfloor* modules
  • stock-logistics-reservation : promise stuffs and reserve rule
  • stock-logistics-release-channel : release channel *
  • stock-logistics-workflow : dyn routing, batch creation, storage type, warehouse flow
  • delivery-carrier : delivery_carrier_warehouse (already merged, I was too quick..)

I can add shopfloor and reservation repos here.

@hparfr
Copy link

hparfr commented Jan 24, 2025

stock_logistics_delivery_carrier to be consistent

@rousseldenis
Copy link
Contributor Author

stock_logistics_delivery_carrier

No, no. We use existing delivery-carrier repo.

@rousseldenis rousseldenis changed the title [ADD] Release Channels repository [ADD] Logistics: Release Channel, Reservation and Shopfloor repositories Jan 24, 2025
@simahawk
Copy link
Contributor

The idea behind "WMS" was to have meaningful name for a WMS solution.
What I suggest: we could move around the specific modules and keep or create in WMS only modules that provide a bundle of feature for specific WMS cases.

@rousseldenis
Copy link
Contributor Author

The idea behind "WMS" was to have meaningful name for a WMS solution. What I suggest: we could move around the specific modules and keep or create in WMS only modules that provide a bundle of feature for specific WMS cases.

Yes, in fact, WMS is more a "verticalization" as this should point to useful modules to do a complete WMS solution.

Maybe, this repo could become something more functional.

@simahawk
Copy link
Contributor

Regarding shopfloor: the base modules should be moved to its own repo like shopfloor or shopfloor-app, because it can be used for apps that do not belong to logistics.

@rousseldenis
Copy link
Contributor Author

Regarding shopfloor: the base modules should be moved to its own repo like shopfloor or shopfloor-app, because it can be used for apps that do not belong to logistics.

Agree

@rousseldenis
Copy link
Contributor Author

Regarding shopfloor: the base modules should be moved to its own repo like shopfloor or shopfloor-app, because it can be used for apps that do not belong to logistics.

Or shopfloor-framework as @jbaudoux suggested to me ?

@rousseldenis
Copy link
Contributor Author

@sbidoul

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jbaudoux
Copy link
Contributor

cc @jgrandguillaume

@jbaudoux
Copy link
Contributor

jbaudoux commented Feb 3, 2025

@rousseldenis Can you merge this ?

@jbaudoux
Copy link
Contributor

jbaudoux commented Feb 3, 2025

I though adding in the wms repo README what kind of module needs to go in which repo and link this info in the other stock/delivery/shopfloor repos

@simahawk simahawk merged commit e0889f3 into OCA:master Feb 4, 2025
1 check passed
@simahawk
Copy link
Contributor

simahawk commented Feb 4, 2025

Added shopfloor-app here #70

@jbaudoux
Copy link
Contributor

jbaudoux commented Feb 5, 2025

I though adding in the wms repo README what kind of module needs to go in which repo and link this info in the other stock/delivery/shopfloor repos

See here OCA/wms#979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants