[ADD] report_generate_helper #827
Conversation
matthieusaison
force-pushed
the
16.0-report_generate_helper
branch
from
505c4a5 to
d309e48
Compare
| def _get_report_converter(self): | ||
| return f"_render_{self.report_type.replace('-', '_')}" | ||
|
|
||
| def get_report(self, report_name): |
There was a problem hiding this comment.
It would be nice to add a minimal documentation that at least specify that a call to the method will return a tuple filename / content....
| def _get_report_converter(self): | ||
| return f"_render_{self.report_type.replace('-', '_')}" | ||
|
|
||
| def get_report(self, report_name): |
There was a problem hiding this comment.
A better name could be generate_report.... get_report could mean 'give me the report record for the given report name'
There was a problem hiding this comment.
Is it intended that this method is public (xml-rpc callable?).
There was a problem hiding this comment.
No it's not necessary, I change to _generate_report
| _inherit = "base" | ||
|
|
||
| def _get_report_converter(self): | ||
| return f"_render_{self.report_type.replace('-', '_')}" |
There was a problem hiding this comment.
I would add this method to another model that extends ir.action.report since that is where report_type is declared. Adding it to a subclass of base is misleading.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sebastienbeau
force-pushed
the
16.0-report_generate_helper
branch
2 times, most recently
from
c1900cd to
475cfef
Compare
sebastienbeau
force-pushed
the
16.0-report_generate_helper
branch
from
475cfef to
0db02d4
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
This PR has the |
|
Congratulations, your PR was merged at b0b3bc8. Thanks a lot for contributing to OCA. ❤️ |
👋 @marielejeune, the get_report helper is here!