Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] base_user_role : migration to 17.0 #331

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] base_user_role : migration to 17.0 #331

wants to merge 1 commit into from

Conversation

loic-mtrl
Copy link

@loic-mtrl loic-mtrl commented Jan 16, 2025 •
edited
Loading

I imported 2 commits from the https://github.com/OCA/server-backend/pull/181/commits pr.

@OCA-git-bot
Copy link
Contributor

Hi @jcdrubay, @sebalix, @novawish,
some modules you are maintaining are being modified, check this out!

@legalsylvain
Copy link
Contributor

Hi. thanks for porting this patch.
could you :

  • rename the name of the PR. somehting like [17.0] module_name : summary
  • squash commit. (In OCA, we avoid to introduce fixup commits).

tyhanks !

@loic-mtrl loic-mtrl changed the title BSQOQ-2595 Oca port pr 181 from 14.0 to 17.0 Oca port pr 181 from 14.0 to 17.0 Jan 17, 2025
@yajo @loic-mtrl
[FIX] base_user_role: Improve tests resiliency
ae6e2c3 
These 2 tests were checking the exact set of groups a user should have.

If these tests are ran in a database where a module is previously installed which adds more groups to the base role, these exact group sets would be inexact, although the behavior that is being tested was actually properly working.

With this patch, basically I'm testing if the user contains the groups from the roles, not the exact role set expected. It should work in integration scenarios.

@Tecnativa TT20468
@loic-mtrl loic-mtrl force-pushed the oca-port-pr-181-from-14.0-to-17.0 branch from c89498c to ae6e2c3 Compare January 17, 2025 09:07
@loic-mtrl loic-mtrl changed the title Oca port pr 181 from 14.0 to 17.0 [17.0] base_user_role : migration to 17.0 Jan 17, 2025
@loic-mtrl loic-mtrl changed the title [17.0] base_user_role : migration to 17.0 [17.0][MIG] base_user_role : migration to 17.0 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemannd leemannd leemannd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loic-mtrl @OCA-git-bot @legalsylvain @leemannd @yajo