Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][IMP] base_user_role - add path in act_window to fit with new url logic #334

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

jdidderen
Copy link

Simple improvement to have a proper url

Before :
image

After :
image

@OCA-git-bot
Copy link
Contributor

Hi @jcdrubay, @sebalix, @novawish,
some modules you are maintaining are being modified, check this out!

@@ -85,10 +85,11 @@
</search>
</field>
</record>
<record model="ir.actions.act_window" id="action_res_users_role_tree">
<record id="action_res_users_role_tree" model="ir.actions.act_window">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of consistency. All other records in the file begin with id=“” and end with model=“”.
If it bothers you, I can remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants