[MIG] base name search improved to 16.0 #2477

maq-adhoc · 2022-11-29T13:14:56Z

No description provided.

Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-9.0/server-tools-9.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-9-0/server-tools-9-0-base_name_search_improved/ca/

- Descriptor: change __openerp__.py file to __manifest__.py also update module version from 9.0.1.0.0 to 11.0.1.0.0 - Update README using guideline - Views: replace view tag openerp to odoo and rename files to match guideline - Models - update imports from openerp to odoo - remove enconding line # -*- coding: utf-8 -*- - update to make it compatible - remove use of SUPERUSER_ID use sudo instead. - rename class name to make it match with guideline. - update methods to match api used in version 11.0 - fix pylint errors - replace use of non exist self._model with self._name - use `Model `is not None instead of if `Model` this becuase the last one is a empty recordset and this one was evaluate to False and never was patching the method. - apply changes resquested/suggested in the PR by the reviewers.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_name_search_improved/

jjscarafia

LGTM.
Tested on runboat, working properly

kikopeiro · 2023-03-14T09:06:46Z

I have detected problems when uninstalling the module. The error obtained is the following

Traceback (most recent call last):
  File "/opt/odoo/odoo-base/odoo-server/odoo/http.py", line 1584, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo-base/odoo-server/odoo/service/model.py", line 134, in retrying
    result = func()
  File "/opt/odoo/odoo-base/odoo-server/odoo/http.py", line 1613, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo-base/odoo-server/odoo/http.py", line 1810, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo-base/odoo-server/odoo/addons/base/models/ir_http.py", line 149, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo-base/odoo-server/odoo/http.py", line 699, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/odoo-base/odoo-server/addons/web/controllers/dataset.py", line 46, in call_button
    action = self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/odoo-base/odoo-server/addons/web/controllers/dataset.py", line 33, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo-base/odoo-server/odoo/api.py", line 461, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo-base/odoo-server/odoo/api.py", line 448, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/odoo-base/odoo-server/odoo/addons/base/wizard/base_module_uninstall.py", line 59, in action_uninstall
    return modules.button_immediate_uninstall()
  File "<decorator-gen-81>", line 2, in button_immediate_uninstall
  File "/opt/odoo/odoo-base/odoo-server/odoo/addons/base/models/ir_module.py", line 76, in check_and_log
    return method(self, *args, **kwargs)
  File "/opt/odoo/odoo-base/odoo-server/odoo/addons/base/models/ir_module.py", line 640, in button_immediate_uninstall
    return self._button_immediate_function(type(self).button_uninstall)
  File "/opt/odoo/odoo-base/odoo-server/odoo/addons/base/models/ir_module.py", line 615, in _button_immediate_function
    registry = modules.registry.Registry.new(self._cr.dbname, update_module=True)
  File "<decorator-gen-14>", line 2, in new
  File "/opt/odoo/odoo-base/odoo-server/odoo/tools/func.py", line 87, in locked
    return func(inst, *args, **kwargs)
  File "/opt/odoo/odoo-base/odoo-server/odoo/modules/registry.py", line 90, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/opt/odoo/odoo-base/odoo-server/odoo/modules/loading.py", line 564, in load_modules
    getattr(py_module, uninstall_hook)(cr, registry)
  File "/opt/odoo/odoo-base/common-16.0/server-tools/base_name_search_improved/hooks.py", line 10, in uninstall_hook
    models.BaseModel._revert_method("fields_view_get")
  File "/opt/odoo/odoo-base/odoo-server/odoo/models.py", line 5031, in _revert_method
    method = getattr(cls, name)
AttributeError: type object 'BaseModel' has no attribute 'fields_view_get'

@maq-adhoc , could you review the problem?

kikopeiro · 2023-03-15T13:06:04Z

Seems work fine! (without code review)

RodrigoBM · 2023-04-20T08:05:52Z

PR MIG: #2412

chusamo

LGTM

OCA-git-bot · 2023-06-06T09:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bguillot · 2023-06-07T15:35:43Z

/ocabot merge nobump

OCA-git-bot · 2023-06-07T15:35:49Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2477-by-bguillot-bump-nobump, awaiting test results.

OCA-git-bot · 2023-06-07T15:49:31Z

Congratulations, your PR was merged at f0a5925. Thanks a lot for contributing to OCA. ❤️

dreispt and others added 30 commits November 29, 2022 08:46

base_name_search_improved: friendly and powerful name search

afa8e90

Return all results from the several methods, ordered by best match

aa9b066

Test if additional domain is honored

23f1eb7

Honor name_search additional domain

8051c95

Do not search on empty string. Fixes OCA#467

be6f96e

Bump version

b16db6e

Fix small typo in readme

98ea832

[9.0] MIG Improved Name Search

11a0200

# Please enter the commit message for your changes. Lines starting

155d499

OCA Transbot updated translations from Transifex

a4ce50f

[UPD] Update base_name_search_improved.pot

eb3d0f0

Translated using Weblate (Catalan)

dd992f8

Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-9.0/server-tools-9.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-9-0/server-tools-9-0-base_name_search_improved/ca/

[UPD] Update base_name_search_improved.pot

f2ecb17

[UPD] README.rst

4879a79

Update translation files

62930a8

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] README.rst

58f6aaa

[IMP] base_name_search_improved: black, isort, prettier

21daec5

[IMP] base_name_search_improved: add v12 imp

bebd42a

[IMP] base_name_search_improved: run pre commit again

3236450

[MIG] base_name_search_improved: Migration to 13.0

6b66b2f

[IMP] base_name_search_improved: patches

a768a1d

[14.0][MIG] base_name_search_improved

e37419a

[UPD] Update base_name_search_improved.pot

879163b

[UPD] README.rst

803a35c

[UPD] Update base_name_search_improved.pot

cea0eb0

[UPD] Update base_name_search_improved.pot

c9e2b34

[UPD] Update base_name_search_improved.pot

e37f796

OCA-git-bot and others added 3 commits November 29, 2022 08:46

[UPD] README.rst

163b36a

[IMP] base_name_search_improved: pre-commit execution

f15efb0

maq-adhoc force-pushed the 16.0-mig-base_name_search_improved branch 4 times, most recently from 21f7996 to 11e7133 Compare November 29, 2022 13:52

jjscarafia approved these changes Nov 30, 2022

View reviewed changes

maq-adhoc force-pushed the 16.0-mig-base_name_search_improved branch from 11e7133 to be034aa Compare November 30, 2022 18:43

maq-adhoc force-pushed the 16.0-mig-base_name_search_improved branch 2 times, most recently from 681c71b to 9d2b445 Compare March 15, 2023 12:04

SoniaViciana mentioned this pull request Mar 30, 2023

[16.0][MIG] base_name_search_improved: Migration to 16.0 #2538

Closed

[MIG] base_name_search_improved: Migration to 16.0

1d55e62

maq-adhoc force-pushed the 16.0-mig-base_name_search_improved branch from 9d2b445 to 1d55e62 Compare May 11, 2023 13:19

kikopeiro mentioned this pull request Jun 5, 2023

[16.0][MIG] base_name_search_improved #2641

Closed

chusamo approved these changes Jun 6, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 6, 2023

SoniaViciana mentioned this pull request Jun 7, 2023

[16.0][mig] account_invoice_search_by_reference: Migration to 16.0 OCA/account-invoicing#1455

Closed

OCA-git-bot added the bot is merging ⏳ label Jun 7, 2023

OCA-git-bot merged commit 64f282e into OCA:16.0 Jun 7, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] base name search improved to 16.0 #2477

[MIG] base name search improved to 16.0 #2477

maq-adhoc commented Nov 29, 2022

jjscarafia left a comment

kikopeiro commented Mar 14, 2023

kikopeiro commented Mar 15, 2023

RodrigoBM commented Apr 20, 2023

chusamo left a comment

OCA-git-bot commented Jun 6, 2023

bguillot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

[MIG] base name search improved to 16.0 #2477

[MIG] base name search improved to 16.0 #2477

Conversation

maq-adhoc commented Nov 29, 2022

jjscarafia left a comment

Choose a reason for hiding this comment

kikopeiro commented Mar 14, 2023

kikopeiro commented Mar 15, 2023

RodrigoBM commented Apr 20, 2023

chusamo left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jun 6, 2023

bguillot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023