-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][ADD] odoo_test_xmlrunner module #2957
base: 17.0
Are you sure you want to change the base?
Conversation
deae97b
to
cb35dca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will test it in real soon
cb35dca
to
e2dcbd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Gitlab. Works like a charm. Thanks! ❤️
|
||
module.current_test = module_name | ||
threading.current_thread().testing = True | ||
results = OdooTestResult() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This returns an empty results
which leads to displaying no test results and fails to exit the process with the correct code. Please have a look at my backport : #3127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paradoxxxzero I trierd your elegant patch on gitlab v17, I just have 1 test in my results
Without your patch I should have 500 tests. Do you have the same behavior in v16 ?
Martin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I will dig, thanks.
odoo_test_xmlrunner/__manifest__.py
Outdated
"website": "https://github.com/OCA/server-tools", | ||
"category": "Tools", | ||
"sequence": 20, | ||
"auto_install": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which is the sense of Autoinstall True?
#3156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,3 @@ | |||
Install python library https://pypi.org/project/unittest-xml-reporting/ | |||
|
|||
The module is automatically installed on the Odoo instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed also.
odoo_test_xmlrunner/requirements.txt
Outdated
@@ -0,0 +1 @@ | |||
unittest-xml-reporting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is useless ? or is it a new OCA convention ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @legalsylvain I tried to remove it and the generation of test-requirements.txt
looks fine. I will remove the odoo_test_xmlrunner/requirements.txt
file.
Martin
https://github.com/orgs/OCA/discussions/167