[17.0][MIG] auto_backup: Migration to 17.0 #2975

rpinset · 2024-06-28T08:12:39Z

second attempt at #2894

Added all the new fields and sentences. This will be the template for translations.

Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.

- Follow template README. - Remove HTML README. - Move models to models folder. - Model and view file names follow guidelines. - Unused methods cleanup. - Remove unneeded `.pot` file. - Fix permissons. - Follow PEP8 in names everywhere. - Set more descriptive field names. - Disable backups for other databases, for security. - Remove db name from generated file, for easier cleanup. - EAFP logic everywhere. - More descriptive name. - Data files moved to YAML, with cleaner ir.cron record creation. - Add permissions for db.backup model. - Icons. - Update tests with new format. - Storage method is a selectable, for easier extensibility. - Instead of custom mailing, it just has a mail thread where you can subscribe. - Should fix almost all comments in OCA#203. - Reduce headers. This respects the upstream license choice (GPL/AGPL) but reduces verbosity. It would be ideal to have everything under AGPL though.

Bump module version to 8.0.1.0.1

* Add self.ensure_ones * Add test coverage

Fixes OCA#710

* [10.0][auto_backup] Menu entry moved * Update version in manifest

Currently translated at 58.2% (32 of 55 strings) Translation: server-tools-11.0/server-tools-11.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/

Added test coverage Added requirements.txt for pysftp Added in the roadmap the exact version of pysftp for this to work (0.2.8) Added in the roadmap the problem with list_db=False Adapted calls to message_post

Currently translated at 17.5% (14 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/pt_BR/

Currently translated at 26.2% (21 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/

Currently translated at 100.0% (80 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/

Currently translated at 51.2% (41 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/hr/

Currently translated at 80.2% (69 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/

rpinset · 2024-06-28T08:19:34Z

@CRogos all the checks are green but I followed the commands on this page for the translations but it didn't work
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

CRogos · 2024-06-28T08:22:22Z

I use the vscode terminal:

git config --global --add rebase.instructionFormat "(%an <%ae>) %s"
git rebase -i origin/17.0
// change "pick" by "f" where needed, and save + close the file.
git push -f

gurneyalex · 2024-07-02T10:16:21Z

/ocabot migration auto_backup

Crazor · 2024-09-03T06:02:08Z

It appears the build task has stalled...

litmount · 2024-09-09T19:24:17Z

It appears the build task has stalled...

It does seems stuck, can anyone with privileges please check on this?

SodexisTeam · 2024-09-25T10:09:07Z

@rpinset

Please add the Python package to the requirements.txt file as shown in the attached screenshot.

Currently, we are using this PR, but we are encountering conflicts in the requirements.txt file while running gitaggregate

SodexisTeam · 2024-09-25T10:11:51Z

@rpinset
When can we expect this PR to be merged?

rpinset · 2024-09-26T07:09:41Z

Please add the Python package to the requirements.txt file as shown in the attached screenshot. Currently, we are using this PR, but we are encountering conflicts in the requirements.txt file while running gitaggregate

Hello @SodexisTeam , I added "pygount" in Requirements.txt but I don't know what external_dependencies require it.
I already use it too. But I'm struggling with the OCA CI, maybe my environment is not optimal and I should redo it.
All tests are OK
@gurneyalex can you try merge ?

percevaq · 2024-10-08T20:15:57Z

It does not work correctly, try to create a directory per backup.

If the path is backups
Create a file for each backup respecting the path and not trying to create a directory for each backup.

rpinset · 2024-11-26T22:30:04Z

It does not work correctly, try to create a directory per backup.

If the path is backups Create a file for each backup respecting the path and not trying to create a directory for each backup.

Hello @percevaq
There has been no code change at this level since v16 and the v17 installation is functional for me.
Does your comment only come from reading the code or from tests?

Have a good day

rpinset · 2024-11-26T22:34:42Z

@gurneyalex can you try merge ?

@gurneyalex All tests are OK can you try merge ?

CRogos

The commit history is still not OK:

rpinset · 2024-11-30T07:53:14Z

The commit history is still not OK:

Sorry @CRogos for having commits in September because Bots find a difference between my branch and the destination.
I will take back your git commands minimizing commits, when I have more time to take the head. It is a particular use.

My branch works, if someone is more used to it, fork, pull request and inform here.

lmonterogarcia · 2025-01-09T10:21:46Z

@CRogos @rpinset When can we expect this PR to be merged?

Thanks in advance.

anavarronm1983

I understand that the SFTP connection is made with a username and password or with a username and key. I have tried it both ways, but it throws the same key error even though I don't use a key for the sftp connection.

Christian-RB · 2025-01-30T16:56:35Z

As this PR seems to be stuck I have created a new one #3180 retaining @rpinset authorship and fixing the commit history @CRogos. I’d appreciate your collaboration there

Christian-RB · 2025-01-30T18:03:30Z

I understand that the SFTP connection is made with a username and password or with a username and key. I have tried it both ways, but it throws the same key error even though I don't use a key for the sftp connection.

This is because the remote needs to be in the known_hosts list. The pysft library let you add extra information as a known_host entry IMO it would be nice to implement that as a new field in the configuration

Yenthe666 and others added 30 commits June 28, 2024 09:37

Update english pot file

d437615

Added all the new fields and sentences. This will be the template for translations.

Open FTP session on the last moment possible

1c3baf3

Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.

FIX License type

3d6a350

[FIX] auto_backup: bad reference to field sftp_private_key (OCA#423)

cc09265

Bump module version to 8.0.1.0.1

[FIX] logger db_backup for pysftp (OCA#419)

b81a4b2

[FIX] remove en.po that was erroneously created by transbot

ebe686b

[MIG] auto_backup: Migrate to v9

c7d87ea

* Add self.ensure_ones * Add test coverage

[auto_backup] FIX: failure type notification

17e9158

Fixes OCA#710

[10.0][auto_backup] Menu entry moved (OCA#735)

00a27a0

* [10.0][auto_backup] Menu entry moved * Update version in manifest

FIX sftp unlink path (OCA#767)

88b71e7

Fix icon Test SFTP Connection (OCA#825)

c656093

[11.0][MIG] auto_backup

ff27a89

[FIX] syntax error in nl.po

bf28b7a

Translated using Weblate (Dutch)

f03d703

Currently translated at 58.2% (32 of 55 strings) Translation: server-tools-11.0/server-tools-11.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/

[FIX] auto_backup: Fix NL translation

fb3e0b8

auto_backup: allow to change the format of backup (OCA#1333)

391a85f

[MIG] auto_backup: Migration to 12.0

84b1fe7

Added test coverage Added requirements.txt for pysftp Added in the roadmap the exact version of pysftp for this to work (0.2.8) Added in the roadmap the problem with list_db=False Adapted calls to message_post

Translated using Weblate (Portuguese (Brazil))

77aeca0

Currently translated at 17.5% (14 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/pt_BR/

Translated using Weblate (Chinese (Simplified))

2fd920e

Currently translated at 26.2% (21 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/

Translated using Weblate (Chinese (Simplified))

cf597cd

Currently translated at 100.0% (80 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/

Translated using Weblate (Chinese (Simplified))

2d266de

Currently translated at 100.0% (80 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/

Translated using Weblate (Chinese (Simplified))

3712175

Currently translated at 100.0% (80 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/

Translated using Weblate (Croatian)

4eb0780

Currently translated at 51.2% (41 of 80 strings) Translation: server-tools-12.0/server-tools-12.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/hr/

[IMP] auto_backup: black, isort, prettier

a1f407d

[MIG] auto_backup: Migration to 13.0

524391c

[IMP] auto_backup: black, isort, prettier

17defb7

[14.0][MIG]auto_backup

c8cd3a5

[FIX] Tests with mock

16aa474

Translated using Weblate (Italian)

4577e80

Currently translated at 80.2% (69 of 86 strings) Translation: server-tools-14.0/server-tools-14.0-auto_backup Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/

rpinset added 2 commits June 28, 2024 09:47

[IMP] : pre-commit auto fixes

97bbf13

[MIG] auto_backup: Migration to 17.0

766b79a

rpinset mentioned this pull request Jun 28, 2024

[17.0][MIG] auto_backup: Migration to 17.0 #2894

Closed

rpinset marked this pull request as draft June 28, 2024 08:15

rpinset closed this Jun 28, 2024

rpinset reopened this Jun 28, 2024

rpinset marked this pull request as ready for review June 28, 2024 08:19

OCA-git-bot added this to the 17.0 milestone Jul 2, 2024

OCA-git-bot mentioned this pull request Jul 2, 2024

Migration to version 17.0 #2752

Open

35 tasks

rpinset added 2 commits September 26, 2024 08:55

Merge branch '17.0' into 17.0-mig-auto_backup

5a4d91a

pygount

d4ae0f7

CRogos reviewed Nov 27, 2024

View reviewed changes

mtbochaca approved these changes Jan 5, 2025

View reviewed changes

anavarronm1983 reviewed Jan 16, 2025

View reviewed changes

Christian-RB mentioned this pull request Jan 30, 2025

[17.0][MIG] auto_backup: Migration to 17.0 #3180

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] auto_backup: Migration to 17.0 #2975

[17.0][MIG] auto_backup: Migration to 17.0 #2975

rpinset commented Jun 28, 2024

rpinset commented Jun 28, 2024

CRogos commented Jun 28, 2024 •

edited

Loading

gurneyalex commented Jul 2, 2024

Crazor commented Sep 3, 2024

litmount commented Sep 9, 2024

SodexisTeam commented Sep 25, 2024

SodexisTeam commented Sep 25, 2024

rpinset commented Sep 26, 2024

percevaq commented Oct 8, 2024

rpinset commented Nov 26, 2024

rpinset commented Nov 26, 2024

CRogos left a comment

rpinset commented Nov 30, 2024

lmonterogarcia commented Jan 9, 2025 •

edited

Loading

anavarronm1983 left a comment

Christian-RB commented Jan 30, 2025

Christian-RB commented Jan 30, 2025

[17.0][MIG] auto_backup: Migration to 17.0 #2975

Are you sure you want to change the base?

[17.0][MIG] auto_backup: Migration to 17.0 #2975

Conversation

rpinset commented Jun 28, 2024

rpinset commented Jun 28, 2024

CRogos commented Jun 28, 2024 • edited Loading

gurneyalex commented Jul 2, 2024

Crazor commented Sep 3, 2024

litmount commented Sep 9, 2024

SodexisTeam commented Sep 25, 2024

SodexisTeam commented Sep 25, 2024

rpinset commented Sep 26, 2024

percevaq commented Oct 8, 2024

rpinset commented Nov 26, 2024

rpinset commented Nov 26, 2024

CRogos left a comment

Choose a reason for hiding this comment

rpinset commented Nov 30, 2024

lmonterogarcia commented Jan 9, 2025 • edited Loading

anavarronm1983 left a comment

Choose a reason for hiding this comment

Christian-RB commented Jan 30, 2025

Christian-RB commented Jan 30, 2025

CRogos commented Jun 28, 2024 •

edited

Loading

lmonterogarcia commented Jan 9, 2025 •

edited

Loading