[ADD] - auth_admin_passkey: migrated to version 9.0 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| { | ||
| 'name': 'Authentification - Admin Passkey', | ||
| 'version': '8.0.2.1.1', | ||
| 'version': '9.0.0.1', |
|
Done 👍 |
|
|
||
| { | ||
| 'name': 'Authentification - Admin Passkey', | ||
| 'version': '8.0.2.1.1', | ||
| 'version': '9.0.1.0.0', |
There was a problem hiding this comment.
I think the minors of the version number should be preserved (i.e. 9.0.2.1.1) since the feature set has not changed.
There was a problem hiding this comment.
Most of the migrated modules have 9.0.1.0.0 as version number, so maybe resetting the version number seems to be a approved convention.
There was a problem hiding this comment.
Indeed you should reset the version number
|
Code review okay 👍 Thanks for migrating! |
|
It could be cool to update the README.rst file to follow the OCA template: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst |
|
As this PR passes the module to new API, we superseed this PR with it: #522 |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (9.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.