Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][9.0][auth_supplier] Migrate. #434

Merged
merged 16 commits into from
May 27, 2016

Conversation

yajo
Copy link
Member

@yajo yajo commented May 26, 2016

Update to v9, with mostly cosmetic changes.

@Tecnativa #271

@pedrobaeza pedrobaeza mentioned this pull request May 26, 2016
59 tasks
@moylop260
Copy link
Contributor

👍 thanks

@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<openerp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to to use the new "cool" tag (and to avoid the need to change it when the other tag will be deprecated)

@pedrobaeza
Copy link
Member

👍

Configuration
=============

* To enable users to create accounts:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can include here that "Developer mode" should be activated first to have access to "Technical features".

@coveralls
Copy link

coveralls commented May 27, 2016

Coverage Status

Coverage increased (+0.4%) to 73.436% when pulling fed5f84 on Tecnativa:9.0-auth_supplier-migration into c4f7a86 on OCA:9.0.

To use this module, you need to:

* Log out.
* In home page, press *Sign in*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Sign in/Sign up/ (tested on runbot)

@sebalix
Copy link
Contributor

sebalix commented May 27, 2016

A little remark, maybe mention it as a Known issue, but 👍

@coveralls
Copy link

coveralls commented May 27, 2016

Coverage Status

Coverage increased (+0.4%) to 73.436% when pulling eb0e9f7 on Tecnativa:9.0-auth_supplier-migration into c4f7a86 on OCA:9.0.

@moylop260 moylop260 merged commit 5b7c2ea into OCA:9.0 May 27, 2016
@pedrobaeza pedrobaeza deleted the 9.0-auth_supplier-migration branch May 27, 2016 17:25
yajo added a commit to Tecnativa/server-tools that referenced this pull request Jun 3, 2016
The whole purpose of this module was to be able to separate a customer and a supplier portals.

Given the status of the upstream implementations of portals, it is not possible to have a supplier portal without portal permissions. Thus, it would be required to make the group this module was creating inherit from `base.group_portal`, which would give suppliers access to all customers portal. As such, that group becomes useless.

From now on, this distinction should be made with simply checking if `user.customer` or `user.supplier` is `True`. To allow that, I'm implementing what was discussed at OCA#434 (diff).

Tests had to be removed because odoo/odoo#12237 makes the created record to disappear, so there's no way to actually check the created user was created with customer or supplier flag on.
yajo added a commit to Tecnativa/server-tools that referenced this pull request Jun 3, 2016
The whole purpose of this module was to be able to separate a customer and a supplier portals.

Given the status of the upstream implementations of portals, it is not possible to have a supplier portal without portal permissions. Thus, it would be required to make the group this module was creating inherit from `base.group_portal`, which would give suppliers access to all customers portal. As such, that group becomes useless.

From now on, this distinction should be made with simply checking if `user.customer` or `user.supplier` is `True`. To allow that, I'm implementing what was discussed at OCA#434 (diff).

Tests had to be removed because odoo/odoo#12237 makes the created record to disappear, so there's no way to actually check the created user was created with customer or supplier flag on.
yajo added a commit to Tecnativa/server-tools that referenced this pull request Jun 3, 2016
The whole purpose of this module was to be able to separate a customer and a supplier portals.

Given the status of the upstream implementations of portals, it is not possible to have a supplier portal without portal permissions. Thus, it would be required to make the group this module was creating inherit from `base.group_portal`, which would give suppliers access to all customers portal. As such, that group becomes useless.

From now on, this distinction should be made with simply checking if `user.customer` or `user.supplier` is `True`. This means no additional problems since `ir.rule` domains can use the `user` variable. To allow that, I'm implementing what was discussed at OCA#434 (diff).

Tests had to be removed because odoo/odoo#12237 makes the created record to disappear, so there's no way to actually check the created user was created with customer or supplier flag on.
JosDeGraeve pushed a commit to apertoso/server-tools that referenced this pull request Jun 13, 2016
* [ADD] auth_supplier: New Module.

* [ADD] auth_supplier: New Module.

* [FIX] auth_supplier: Change author order.

* [MIG][9.0][auth_supplier] Migrate.

Update to v9, with mostly cosmetic changes.

* Update XML tags.

* Inform about the need to have technical features enabled.

* Don't assume website is installed.

* Add known issue
yajo added a commit to Tecnativa/server-tools that referenced this pull request Jun 28, 2016
The whole purpose of this module was to be able to separate a customer and a supplier portals.

Given the status of the upstream implementations of portals, it is not possible to have a supplier portal without portal permissions. Thus, it would be required to make the group this module was creating inherit from `base.group_portal`, which would give suppliers access to all customers portal. As such, that group becomes useless.

From now on, this distinction should be made with simply checking if `user.customer` or `user.supplier` is `True`. This means no additional problems since `ir.rule` domains can use the `user` variable. To allow that, I'm implementing what was discussed at OCA#434 (diff).

Tests had to be removed because odoo/odoo#12237 makes the created record to disappear, so there's no way to actually check the created user was created with customer or supplier flag on.
JayVora-SerpentCS pushed a commit to JayVora-SerpentCS/server-tools that referenced this pull request Sep 12, 2016
* [ADD] auth_supplier: New Module.

* [ADD] auth_supplier: New Module.

* [FIX] auth_supplier: Change author order.

* [MIG][9.0][auth_supplier] Migrate.

Update to v9, with mostly cosmetic changes.

* Update XML tags.

* Inform about the need to have technical features enabled.

* Don't assume website is installed.

* Add known issue
JayVora-SerpentCS pushed a commit to JayVora-SerpentCS/server-tools that referenced this pull request Sep 12, 2016
The whole purpose of this module was to be able to separate a customer and a supplier portals.

Given the status of the upstream implementations of portals, it is not possible to have a supplier portal without portal permissions. Thus, it would be required to make the group this module was creating inherit from `base.group_portal`, which would give suppliers access to all customers portal. As such, that group becomes useless.

From now on, this distinction should be made with simply checking if `user.customer` or `user.supplier` is `True`. This means no additional problems since `ir.rule` domains can use the `user` variable. To allow that, I'm implementing what was discussed at OCA#434 (diff).

Tests had to be removed because odoo/odoo#12237 makes the created record to disappear, so there's no way to actually check the created user was created with customer or supplier flag on.
dsolanki-initos pushed a commit to initOS/server-tools that referenced this pull request Feb 14, 2020
* [ADD] auth_supplier: New Module.

* [ADD] auth_supplier: New Module.

* [FIX] auth_supplier: Change author order.

* [MIG][9.0][auth_supplier] Migrate.

Update to v9, with mostly cosmetic changes.

* Update XML tags.

* Inform about the need to have technical features enabled.

* Don't assume website is installed.

* Add known issue
dsolanki-initos pushed a commit to initOS/server-tools that referenced this pull request Feb 14, 2020
The whole purpose of this module was to be able to separate a customer and a supplier portals.

Given the status of the upstream implementations of portals, it is not possible to have a supplier portal without portal permissions. Thus, it would be required to make the group this module was creating inherit from `base.group_portal`, which would give suppliers access to all customers portal. As such, that group becomes useless.

From now on, this distinction should be made with simply checking if `user.customer` or `user.supplier` is `True`. This means no additional problems since `ir.rule` domains can use the `user` variable. To allow that, I'm implementing what was discussed at OCA#434 (diff).

Tests had to be removed because odoo/odoo#12237 makes the created record to disappear, so there's no way to actually check the created user was created with customer or supplier flag on.
dsolanki-initos pushed a commit to initOS/server-tools that referenced this pull request Dec 16, 2020
* [ADD] auth_supplier: New Module.

* [ADD] auth_supplier: New Module.

* [FIX] auth_supplier: Change author order.

* [MIG][9.0][auth_supplier] Migrate.

Update to v9, with mostly cosmetic changes.

* Update XML tags.

* Inform about the need to have technical features enabled.

* Don't assume website is installed.

* Add known issue
dsolanki-initos pushed a commit to initOS/server-tools that referenced this pull request Dec 16, 2020
The whole purpose of this module was to be able to separate a customer and a supplier portals.

Given the status of the upstream implementations of portals, it is not possible to have a supplier portal without portal permissions. Thus, it would be required to make the group this module was creating inherit from `base.group_portal`, which would give suppliers access to all customers portal. As such, that group becomes useless.

From now on, this distinction should be made with simply checking if `user.customer` or `user.supplier` is `True`. This means no additional problems since `ir.rule` domains can use the `user` variable. To allow that, I'm implementing what was discussed at OCA#434 (diff).

Tests had to be removed because odoo/odoo#12237 makes the created record to disappear, so there's no way to actually check the created user was created with customer or supplier flag on.
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants