Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] mail_inline_css: Migrate to version 16.0 #1124

Merged
merged 23 commits into from
Mar 4, 2024
Merged

[16.0][MIG] mail_inline_css: Migrate to version 16.0 #1124

merged 23 commits into from
Mar 4, 2024

Conversation

sonhd91
Copy link

@sonhd91 sonhd91 commented Apr 5, 2023 •
edited
Loading

@sonhd91 sonhd91 mentioned this pull request Apr 6, 2023
Open
39 tasks
simahawk
simahawk reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG pls drop the test dep

@sonhd91 sonhd91 force-pushed the 16.0-mig-mail_inline_css branch from a3a6297 to 79eafa7 Compare July 18, 2023 02:54
@sonhd91
Copy link
Author

sonhd91 commented Jul 18, 2023

LG pls drop the test dep

Droped test-requirements.txt, please checked again

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 19, 2023
@sonhd91
Copy link
Author

sonhd91 commented Nov 20, 2023 •
edited
Loading

@simahawk can you merge it ?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 26, 2023
@StephaneMangin
Copy link
Contributor

Hi @sonhd91 Could you rebase your PR please ? It blocks the merge.

bealdav and others added 20 commits March 4, 2024 23:23
@bealdav
ADD module mail_inline_css
d7edb96
@bealdav
IMP README use case
b73e213
@oca-transbot
OCA Transbot updated translations from Transifex
2c01f7c
[11.0][MIG] mail_inline_css
5905ab1
[IMP] mail_inline_css: Improve and add test cov
147c7d2
[IMP] mail_inline_css: allow passing options to premailer
1067dbe
@OCA-git-bot
[ADD] icon.png
b409884
@simahawk
[MIG] mail_inline_css: Migration to 12.0
6721322
@simahawk
mail_inline_css: unify premailer transform apply
e09f4f4
@oca-transbot
Update translation files
d3ae418 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-12.0/social-12.0-mail_inline_css
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_inline_css/
@simahawk
[REF] mail_inline_css: apply pre-commit
1e14677
@simahawk
[MIG] mail_inline_css: Migration to 13.0
601f6de
@guewen
Fix issue on empty template with premailer
6429d5f 
If premailer receives an empty value, such as an empty string,
on parsing, it returns None and fails when trying to call
'etree.fromstring()' on this None result.

We should avoid to call premailer on an empty string, as the result
will anyway not change.

We may have an empty template for instance when a template could not
compile due to a mistake.
@OCA-git-bot
mail_inline_css 13.0.1.0.1
138770f
@simahawk
mail_inline_css: fix transform hook
ccc5b27 
The mail module offers a better hook to manipulate html: `render_post_process`.
By using this, we make sure the transform is applied properly
before html tags sanitizing happens,
which can alter - if not screw - the final result.

Finally, it simplifies code :)
@OCA-git-bot
mail_inline_css 13.0.1.0.2
6cc6473
[IMP] pre-commit run -a
786f220
@phuctranfxvn
[MIG] mail_inline_css: Migration to 14.0
4988a14
@oca-transbot
Update translation files
75c8caa 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-14.0/social-14.0-mail_inline_css
Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_inline_css/
@OCA-git-bot
[IMP] update dotfiles [ci skip]
dc15dd5
@sonhd91 sonhd91 force-pushed the 16.0-mig-mail_inline_css branch from 79eafa7 to f90908a Compare March 4, 2024 16:24
@sonhd91
Copy link
Author

sonhd91 commented Mar 4, 2024

Hi @sonhd91 Could you rebase your PR please ? It blocks the merge.

Okay

@simahawk
Copy link
Contributor

simahawk commented Mar 4, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1124-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c32d794 into OCA:16.0 Mar 4, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 390e82a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sonhd91 @StephaneMangin @simahawk @OCA-git-bot @bealdav @oca-transbot @guewen @phuctranfxvn @bizzappdev