Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] mail_quoted_reply: fix duplicating reply icon #1242

Closed
wants to merge 1 commit into from
Closed

[FIX] mail_quoted_reply: fix duplicating reply icon #1242

wants to merge 1 commit into from

Conversation

em230418
Copy link

Fixes #1239

@em230418 em230418 mentioned this pull request Oct 20, 2023
Merged
@jonasbuchholz
Copy link
Contributor

@etobella could you review this fix?

@etobella
Copy link
Member

It works better now, but I was able to reproduce the error on runboat for the PR

image

@etobella
Copy link
Member

image

How to reproduce the error:

  • Mark a message
  • Click on the recipent
  • Go Back to the original thread: Now you have two elements

@jonasbuchholz
Copy link
Contributor

You are correct, leaving the thread and coming back to it adds additional icons. I tried a different fix in #1185 that doesn't seem to have that issue, but it has a little more overhead because it checks the action list every time. @em230418 what do you think?

@etobella
Copy link
Member

I prefer the other option, as the bug is shouldn't be there 😉

@em230418 em230418 closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasbuchholz jonasbuchholz jonasbuchholz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@em230418 @jonasbuchholz @etobella