-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mail_activity_team: Fix bug of the Team Activities filter. #1280
mail_activity_team: Fix bug of the Team Activities filter. #1280
Conversation
a61b08b
to
2fff981
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good in principle!
@rven do you agree with this change on your code from 0b8446e#diff-6124414e0966c0a812d33b40164341edf8bd0a0cdca975e5396c720a802f2f68 ?
Oh, please prefix the commit messsage with |
Hi @ntodorova, could you please take a look at those suggestions above? |
ae92061
to
d1aca63
Compare
4a00e26
to
2bacd94
Compare
@sonhd91, |
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 969c37a. Thanks a lot for contributing to OCA. ❤️ |
Taken from the 16.0 branch after the merge of OCA#1280 which was picked for the migration of this module for 17.0 in an earlier stage.
For 17.0, see #1352 |
Taken from the 16.0 branch after the merge of OCA#1280 which was picked for the migration of this module for 17.0 in an earlier stage.
Bugfix: If you go to the tray menu via the activities and then display Late/Today/Future activities, activities that are only assigned to the team and not to the user are not displayed.
Reproduce:
. create a new team
. add user/s to the team
. create an Activity for today for the team, but leave the "Team user" field empty
. go to the Tray menu
. click Team Activities
. click Today
Before: nothing was shown
Now: the related object from the team today's activity is shown