Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail_activity_team: Fix bug of the Team Activities filter. #1280

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ntodorova
Copy link
Member

Bugfix: If you go to the tray menu via the activities and then display Late/Today/Future activities, activities that are only assigned to the team and not to the user are not displayed.

Reproduce:
. create a new team
. add user/s to the team
. create an Activity for today for the team, but leave the "Team user" field empty
. go to the Tray menu
. click Team Activities
. click Today
Before: nothing was shown
Now: the related object from the team today's activity is shown

@ntodorova ntodorova force-pushed the 16.0-mail_activity_team_filter_bug branch 3 times, most recently from a61b08b to 2fff981 Compare January 12, 2024 12:10
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in principle!

@rven do you agree with this change on your code from 0b8446e#diff-6124414e0966c0a812d33b40164341edf8bd0a0cdca975e5396c720a802f2f68 ?

mail_activity_team/models/mail_activity_mixin.py Outdated Show resolved Hide resolved
@StefanRijnhart
Copy link
Member

Oh, please prefix the commit messsage with [FIX] (as per https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#L1140-L1141)

@sonhd91
Copy link

sonhd91 commented Feb 19, 2024

Hi @ntodorova, could you please take a look at those suggestions above?

@ntodorova ntodorova force-pushed the 16.0-mail_activity_team_filter_bug branch 2 times, most recently from ae92061 to d1aca63 Compare March 13, 2024 10:52
@ntodorova ntodorova force-pushed the 16.0-mail_activity_team_filter_bug branch from 4a00e26 to 2bacd94 Compare March 13, 2024 11:07
@ntodorova
Copy link
Member Author

ntodorova commented Mar 13, 2024

@sonhd91,
I have implemented the changes suggested in the comments, but it seems the tests of another module are failing. Anyways those seems not related to this PR.

@StefanRijnhart
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1280-by-StefanRijnhart-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4917efe into OCA:16.0 Apr 17, 2024
3 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 969c37a. Thanks a lot for contributing to OCA. ❤️

StefanRijnhart pushed a commit to StefanRijnhart/social that referenced this pull request Apr 17, 2024
Taken from the 16.0 branch after the merge of OCA#1280
which was picked for the migration of this module for 17.0 in an earlier stage.
@StefanRijnhart
Copy link
Member

For 17.0, see #1352

Wodran14 pushed a commit to DynAppsNV/social that referenced this pull request Jan 23, 2025
Taken from the 16.0 branch after the merge of OCA#1280
which was picked for the migration of this module for 17.0 in an earlier stage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants