[17.0][UPD] copier version 1.20 #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedrobaeza please review |
|
Please check pre-commit CI |
MohamedOsman7
force-pushed
the
17.0-imp-update-copier
branch
from
b0e8915 to
e725b15
Compare
pedrobaeza
requested changes
Mar 11, 2024
mail_activity_board/__manifest__.py
Outdated
Comment on lines
11
to
12
| "author": """SDi, David Juaneda, Sodexis, ACSONE SA/NV, | ||
| Odoo Community Association (OCA)""", |
There was a problem hiding this comment.
Don't make literal multi-line strings, or the spaces and newlines will be part of the author field:
Suggested change
| "author": """SDi, David Juaneda, Sodexis, ACSONE SA/NV, | |
| Odoo Community Association (OCA)""", | |
| "author": "SDi, David Juaneda, Sodexis, ACSONE SA/NV," | |
| "Odoo Community Association (OCA)", |
| @@ -159,7 +159,8 @@ def test_01_from_outgoing_server_domainone(self): | |||
| self.assertEqual( | |||
| used_mail_server, | |||
| expected_mail_server, | |||
| f"It using {used_mail_server.name} but we expect to use {expected_mail_server.name}", | |||
| f"""It using {used_mail_server.name} | |||
There was a problem hiding this comment.
Incorrect due to the same reason (and all of them).
|
@pedrobaeza how can i fix it? Should it then be ignored it with "# noqa: E501"? |
|
I have already told you what is the solution. |
MohamedOsman7
force-pushed
the
17.0-imp-update-copier
branch
from
e725b15 to
b99d2f1
Compare
MohamedOsman7
force-pushed
the
17.0-imp-update-copier
branch
from
b99d2f1 to
65e6f69
Compare
hbrunn
approved these changes
Mar 20, 2024
|
@pedrobaeza do you agree this is okay now? |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 449852b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.