[16.0][FIX] mail_composer_cc_bcc: fix duplicate key value error "unique_mail_message_id_res_partner_id_if_set" #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hailangvn2023, |
|
|
trisdoan
force-pushed
the
16.0-fix-mail_composer_cc_bcc
branch
2 times, most recently
from
a98eb90 to
481b6d8
Compare
trisdoan
force-pushed
the
16.0-fix-mail_composer_cc_bcc
branch
from
481b6d8 to
9bfe604
Compare
trisdoan
force-pushed
the
16.0-fix-mail_composer_cc_bcc
branch
from
9bfe604 to
c28a54c
Compare
hbrunn
requested changes
Jan 9, 2025
| cls.admin_user = cls.env.ref("base.user_admin") | ||
|
|
||
| def test_tracking_mail_without_cc_bcc(self): | ||
| if "purchase.order" in self.env: |
There was a problem hiding this comment.
please find a way to write this test without relying on models we don't have in the OCA CI run. Can't you test the same with ie users and the subtypes the mail module provides?
There was a problem hiding this comment.
Hello @hbrunn, agreed, I just updated the test to mimic the flow
…onstraint "unique_mail_message_id_res_partner_id_if_set" when adding the same user to CC field that is already set as a follower
trisdoan
force-pushed
the
16.0-fix-mail_composer_cc_bcc
branch
2 times, most recently
from
1110603 to
4cbce87
Compare
trisdoan
force-pushed
the
16.0-fix-mail_composer_cc_bcc
branch
from
4cbce87 to
15f7086
Compare
hbrunn
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
https://github.com/OCA/social/issues/1263https://github.com/OCA/social/pull/1309https://github.com/OCA/social/pull/1310#issuecomment-2186838432, which was not covered.17.0: usingres.partnerinsteadproduct.templatein test. Otherwise, tests cannot run because model product.template is not in environment.Result
mail_composer_cc_bcc_16.webm