Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mail_template_attach_existing_attachment #1543

Open
wants to merge 3 commits into
base: 17.0
Choose a base branch
from

Conversation

damdam-s
Copy link
Member

No description provided.

petrus-v and others added 2 commits January 15, 2025 15:58
This module, based on  allow to define
_
to pre-select existing attachment that matched with file name to send in
compose mail.

This module is designed to work in mass mailing to select proper
files to attached from mail template configuration.

reviews:

Co-authored-by: Hpar <[email protected]>
Co-authored-by: Marc Hertzog <[email protected]>
@damdam-s damdam-s force-pushed the 17.0-mig-mail_template_attach_existing_attachment branch 2 times, most recently from 05b2230 to e0112ac Compare January 16, 2025 10:22
@damdam-s damdam-s force-pushed the 17.0-mig-mail_template_attach_existing_attachment branch from e0112ac to a0eda44 Compare January 16, 2025 10:30
Copy link

@petrus-v petrus-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to handle this migration, code looks good to me

Copy link

@alexandregaldeano alexandregaldeano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants