[17.0][mig] mail_attach_existing_attachment_account #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] README.rst [ADD] icon.png [UPD] Update mail_attach_existing_attachment_account.pot [UPD] README.rst
TT28899 [UPD] Update mail_attach_existing_attachment_account.pot [UPD] README.rst
…ti-company Doing a bulk search on accounts without company filter can lead to selecting an account of other company, and thus, making the test to fail. We restrict the account search to the current company.
We show the field with the same technique as in the base module, which improves the display, showing the label.
Currently translated at 50.0% (1 of 2 strings) Translation: social-16.0/social-16.0-mail_attach_existing_attachment_account Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_attach_existing_attachment_account/it/
Currently translated at 100.0% (2 of 2 strings) Translation: social-16.0/social-16.0-mail_attach_existing_attachment_account Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_attach_existing_attachment_account/it/
damdam-s
force-pushed
the
17.0-mig-mail_attach_existing_attachment_account2
branch
from
a073f31 to
d701bc5
Compare
damdam-s
force-pushed
the
17.0-mig-mail_attach_existing_attachment_account2
branch
from
c1132cd to
1ff4372
Compare
alexandregaldeano
approved these changes
Jan 24, 2025
Comment on lines
+37
to
+43
| # def _prepare_mail_values(self, res_ids): | ||
| # res = super()._prepare_mail_values(res_ids) | ||
| # if self.object_attachment_ids.ids and self.model and len(res_ids) == 1: | ||
| # res[res_ids[0]].setdefault("attachment_ids", []).extend( | ||
| # self.object_attachment_ids.ids | ||
| # ) | ||
| # return res |
There was a problem hiding this comment.
Remove this commented out code please :)
| name="object_attachment_ids" | ||
| widget="many2many_checkboxes" | ||
| domain="[('res_model', '=', 'account.move'), ('res_id', 'in', move_ids)]" | ||
| invisible="can_attach_attachment==False" |
There was a problem hiding this comment.
Suggested change
| invisible="can_attach_attachment==False" | |
| invisible="not can_attach_attachment" |
?
petrus-v
reviewed
Jan 24, 2025
Comment on lines
+37
to
+43
| # def _prepare_mail_values(self, res_ids): | ||
| # res = super()._prepare_mail_values(res_ids) | ||
| # if self.object_attachment_ids.ids and self.model and len(res_ids) == 1: | ||
| # res[res_ids[0]].setdefault("attachment_ids", []).extend( | ||
| # self.object_attachment_ids.ids | ||
| # ) | ||
| # return res |
There was a problem hiding this comment.
I suppose comment code could be removed
carlos-lopez-tecnativa
suggested changes
Jan 27, 2025
| res["can_attach_attachment"] = True # pragma: no cover | ||
| return res | ||
|
|
||
| can_attach_attachment = fields.Boolean() |
There was a problem hiding this comment.
Remove the duplicate field; it is already declared at the top of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.