[17.0][IMP] mail_notification_custom_subject: Do not replace the subject if it is already defined + add inside replace option #1548
+106
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yajo, |
pedrobaeza
reviewed
Jan 16, 2025
There was a problem hiding this comment.
I see the subject_to_replace feature very limited, as you can only do one replacement. But I think it's not needed as well, as you can do a whole replacement and use expressions to paint that. And anyway, for the particular case we need it, we should use a stored value in the mail template (object.partner_id.comercial or object.name if I'm not wrong).
|
It is important to clarify that you can set several inside template records to make several replacements if necessary. I will change the behavior of the |
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
from
809d101 to
9469da8
Compare
yajo
requested changes
Jan 17, 2025
mail_notification_custom_subject/models/mail_message_custom_subject.py
Outdated
Show resolved
Hide resolved
mail_notification_custom_subject/models/mail_message_custom_subject.py
Outdated
Show resolved
Hide resolved
mail_notification_custom_subject/models/mail_message_custom_subject.py
Outdated
Show resolved
Hide resolved
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
from
9469da8 to
7594aa1
Compare
victoralmau
added a commit
to Tecnativa/social
that referenced
this pull request
Jan 17, 2025
…ing the subject If there is an error in the template we want to render the subject to be shown and acted upon. Related to OCA#1548 (comment) TT52259
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
2 times, most recently
from
eb7d3ac to
adb7204
Compare
pedrobaeza
reviewed
Jan 17, 2025
… it is already set If we write something from the mail thread (without subject) it is only when it should replace the subject. TT52259
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
from
adb7204 to
25d92ad
Compare
pedrobaeza
reviewed
Jan 20, 2025
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
from
25d92ad to
3da990f
Compare
pedrobaeza
approved these changes
Jan 20, 2025
yajo
requested changes
Jan 20, 2025
…ception to know what has happened TT52259
Example use Case: Our company is called: MY_COMPANY_NAME but is known as MCN, we want to replace in some places the subject line so that it is sent with MCN TT52259
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
from
3da990f to
08b5dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done:
Please @pedrobaeza and @sergio-teruel can you review it?
@Tecnativa TT52259