-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0] [MIG] storage_image_product_import: Migration to 15.0 #393
base: 15.0
Are you sure you want to change the base?
[15.0] [MIG] storage_image_product_import: Migration to 15.0 #393
Conversation
Test didn't make any sense to me, and they were failing because of changes made in storage_image. I rewrote them in a way that makes sense, and removed the dependency to storage_image_product which was only here for tests I believe.
* fix: azure reading in stream monkey patch documents
* fix: azure reading in stream monkey patch documents
/ocabot migration storage_image_product_import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review only)
This PR looks fantastic, let's merge it! |
@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-393-by-lmignon-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Dependency MR for module
storage_image_import
#392