Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computing overall combined return periods for the overall trigger #11

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

PaulineNimo
Copy link
Collaborator

@zackarno, I computed the RPs here. Would be great if you could have a look at let me know your thoughts. We still do not know how much will be allocated when the trigger is reached.

@zackarno
Copy link

zackarno commented Oct 9, 2024

hey @PaulineNimo - some very interesting stuff here! I am just getting my bearings with the code, but 2 quick questions to get started:

  1. I'm not sure how to leave comments in a PR on .ipynb files. It doesn't seem like you can highlight code chunks and add comments. Is there a way to do that? If not, can we use jupytext ?
  2. at the end of analysis/04.1_historical_validation.ipynb it looks like you create a boolean logicals for the different trigger factors, but it seems like you are giving all year/month combos 2000-current (2024-06) either a TRUE or FALSE, but i think alot of the historical data does not go back this far. Therefore, I think it is better if we only have T/F in years where we have data and keep years outside of this range as NA.

Let me know.

@PaulineNimo
Copy link
Collaborator Author

Hey! @zackarno , I will add the markdown versions. Just churned out the notebooks quickly.
On your second point, makes sense. I can make the change.

@zackarno
Copy link

zackarno commented Dec 3, 2024

hey @PaulineNimo - just was notified of some new commit on this branch. Are you still actively working on it? Happy to give it a look again when you say it's ready.

@PaulineNimo
Copy link
Collaborator Author

Hey! @zackarno The geographical scope changed as well as the wind speed threshold. I'll ping you again once done and share a csv with the historical activations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants